-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help required: query property #75
Conversation
… e.g. "<T extends Base>") * Replaced propertyX with generic property method (with auto-type inference) * Added default to find functions, should the default arg value be 0 or should the address be 0 for NULL? It would be nice to see the actual (closed) source code in this "open" source project.
everything else (e.g. count) is still horribly broken
seems to return a result before the search is actually concluded, there is some non-deterministic behavior here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've found the bug you were looking for WRT count() - should be fine after applying the proposed change (name of the function).
I'll still have to think about how to accomplish having a properly typed find()
method directly on query().build().property() without having to cast.
Wrong ffi function referenced Co-Authored-By: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Code analysis issue Co-Authored-By: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Code analysis issue #2 Co-Authored-By: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Code analysis issue Co-Authored-By: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Found 2 issues * negative (signed) values for integers null replacements * floats don't seem to become null at any point
Merged as part of #108. |
Remaining issues (2020 May 25)
.find(replaceNullWith:-2)
on tLong works, but still not on the other integerish types.So... I'm still stuck 6 months later. Ideas?
Remaining issues (2019 Nov 29)
find
function on tShort and tInteger properties, e.g.find(replaceNullWith: -2)
replaceNullWith
parameter, uninitialized values will always return0.0
.Right now we have:
Where
tInteger
is referenced to return the concreteIntegerPropertyQuery
, but the return type is still the limiting factor, i.e. the compiler will make itPropertyQuery
again, because the generic param<PQ extends PropertyQuery>
requirement applies.We could change the syntax: