Feature 2473/self review completion email communication #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, send to reviewers
…, send to reviewers
…, send to reviewers
mkimberlin
reviewed
Sep 23, 2024
| StringBuilder bodyBuilder = new StringBuilder(String.format("Self-review has been completed by %s %s%s.<br>", | ||
| currentUserProfile.getFirstName(), currentUserProfile.getLastName(), reviewPeriodString)); | ||
| String subject = String.format("%s %s has finished their self-review%s.", currentUserProfile.getFirstName(), currentUserProfile.getLastName(), reviewPeriodString); | ||
| StringBuilder bodyBuilder = new StringBuilder(String.format("Self-review has been completed by %s %s%s.<br>", currentUserProfile.getFirstName(), currentUserProfile.getLastName(), reviewPeriodString)); |
There was a problem hiding this comment.
Something about this line hurts my soul a little. 🤣
mkimberlin
approved these changes
Sep 23, 2024
mkimberlin
deleted the
feature-2473/self-review-completion-email-communication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the email sent upon the completion of a self-review
Modified the email sent to PDL/Supervisor so it's an "FYI"
Made it so an email is also sent to the reviewee's reviewers
Created tickets for additional related work:
Self-Review Email sent to Supervisor/PDL - Include link to review #2595
Self-Review Email (to supervisor/PDL and reviewers) - Send in MJML format #2596