Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinarizeParseMojo generalization #2672

Merged
merged 4 commits into from
Dec 7, 2023
Merged

BinarizeParseMojo generalization #2672

merged 4 commits into from
Dec 7, 2023

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Dec 4, 2023 •
edited by pr-codex bot
Loading

Closes #2649

PR-Codex overview

Detailed summary

  • The focus of this PR is to modify the BinarizeParseMojo class in the eo-maven-plugin project.
  • Notable changes include:
    • Renaming the addRust method to addFFIs.
    • Updating the Javadoc comments to reflect the purpose of the class and methods.
    • Adding a todo comment to make the class more generic and remove dependencies on Rust-specific code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Dec 4, 2023

@levBagryansky @maxonfjvipon could you check this one, please?

levBagryansky
levBagryansky approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@levBagryansky levBagryansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 please check

eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeParseMojo.java Outdated
* think we can implement it, using something like {@code FFINodeFactory}, that will return
* appropriate FFI node for every XML node from {@code nodes}. Also it will be great to move
* paths to XML FFI insert nodes (such as {@code "/program/rusts/rust"}) from this method to
* a class field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 we can specify "static field" here

@maxonfjvipon maxonfjvipon self-requested a review December 4, 2023 16:35
maxonfjvipon
maxonfjvipon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 LGTM! Thanks

@c71n93
Copy link
Member Author

c71n93 commented Dec 4, 2023

@yegor256 could you check this one, please?

1 similar comment
@c71n93
Copy link
Member Author

c71n93 commented Dec 5, 2023

@yegor256 could you check this one, please?

@yegor256
Copy link
Member

yegor256 commented Dec 7, 2023 •
edited
Loading

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 7, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 14ca213 into objectionary:master Dec 7, 2023
12 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 7, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)

@c71n93 c71n93 deleted the 2649-generic-binarize-parse-mojo branch March 20, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

@levBagryansky levBagryansky levBagryansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BinarizeParseMojo.java:145-148: We can make the current...
5 participants
@c71n93 @yegor256 @rultor @levBagryansky @maxonfjvipon