-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2648 refactor bin mojo #2765
Merged
rultor
merged 7 commits into
objectionary:master
from
levBagryansky:2648_refactor-bin-mojo
Jan 11, 2024
Merged
2648 refactor bin mojo #2765
rultor
merged 7 commits into
objectionary:master
from
levBagryansky:2648_refactor-bin-mojo
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@maxonfjvipon please take a look |
maxonfjvipon
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky LGTM! Thanks
@levBagryansky please add issue link to the description of the PR |
@yegor256 please take a look |
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2648
PR-Codex overview
This PR focuses on refactoring and optimizing the
BinarizeParseMojo
class in theeo-maven-plugin
.Detailed summary
BinarizeParse
classBinarizeParseMojoTest
toBinarizeParseTest
BinarizeParseMojo
toBinarizeParse
Buildable
interface for FFI nodes that can be built