Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2648 refactor bin mojo #2765

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Jan 10, 2024

Closes #2648

PR-Codex overview

This PR focuses on refactoring and optimizing the BinarizeParseMojo class in the eo-maven-plugin.

Detailed summary

  • Removed unused imports and parameters
  • Extracted logic into a separate BinarizeParse class
  • Renamed BinarizeParseMojoTest to BinarizeParseTest
  • Updated references to BinarizeParseMojo to BinarizeParse
  • Added Buildable interface for FFI nodes that can be built

The following files were skipped due to too many changes: eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeMojo.java, eo-maven-plugin/src/main/java/org/eolang/maven/rust/RustNode.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please take a look

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky LGTM! Thanks

@maxonfjvipon
Copy link
Member

@levBagryansky please add issue link to the description of the PR

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 11, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 63cb73c into objectionary:master Jan 11, 2024
12 checks passed
@rultor
Copy link
Contributor

rultor commented Jan 11, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

@levBagryansky levBagryansky deleted the 2648_refactor-bin-mojo branch January 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinarizeMojo.java:52-54: Make it more generic. Perhaps by...
4 participants