Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3529): remove abstract attribute #3599

Merged

Conversation

maxonfjvipon
Copy link
Member

Closes: #3529

@github-actions github-actions bot added the core label Dec 3, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit f293ae0 into objectionary:master Dec 4, 2024
17 checks passed
@yegor256
Copy link
Member

yegor256 commented Dec 4, 2024

@maxonfjvipon cool, thanks!

@0crat
Copy link

0crat commented Dec 6, 2024

@maxonfjvipon Thank you for your contribution! We appreciate your effort, but there are a few areas for improvement. You've earned +4 points as a base, but we had to deduct 8 points for exceeding 200 hits-of-code (317), 16 points for lack of code review, and 4 points for insufficient comments (only 1). To ensure you receive some recognition, we've added 28 points, bringing your total to +4. Please remember to keep your contributions smaller and encourage code reviews in the future. Your current balance stands at +32. We look forward to your continued participation and growth within the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the @abstract attribute seems to be redundant
3 participants