Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3706): Found the Bug Related to Token Names #3713

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

volodya-lombrozo
Copy link
Member

In this PR I:

  1. Added human-readable messages to all the tests inside EoIndentLexerTest.
  2. Added two more disabled tests that show the problem with icorrect naming of TAB/UNTAB tokens.

Related to #3706.

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you take a look, please?

@yegor256
Copy link
Member

@maxonfjvipon make sense?

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 yes, actually it's a common and annoying problem. Maybe I even know how to solve it
@volodya-lombrozo LGTM

@volodya-lombrozo
Copy link
Member Author

@yegor256 yes, actually it's a common and annoying problem. Maybe I even know how to solve it @volodya-lombrozo LGTM

@maxonfjvipon Thank you for the review. I've already solved it. The solution just waits for this PR to be merged.

@yegor256 yegor256 merged commit 14a35c6 into objectionary:master Dec 20, 2024
21 checks passed
@yegor256
Copy link
Member

@volodya-lombrozo thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants