Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing profiles(solves invoker-maven-plugin invocation when -DskipITs is set) #3739

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

ArtemGet
Copy link
Contributor

To achieve this logic I added profiles as I mentioned in comment.
Profile activates if corresponding property is set, so there are no need to rewrite any action scripts.
I.E:
-DskipTests -> -PskipTests
-DskipITs -> -PskipITs
-DskipUTs -> -PskipUTs

(-PskipITs and PskipUTs is kind of useless, but i added them to uniformity with -PskipTests)

@github-actions github-actions bot added the core label Dec 23, 2024
@ArtemGet ArtemGet changed the title Add testing profiles(solves invoker-maven-plugin invocation when -DskipTests is set) Add testing profiles(solves invoker-maven-plugin invocation when -DskipITs is set) Dec 23, 2024
@yegor256
Copy link
Member

@maxonfjvipon please, check this one

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Dec 23, 2024

@ArtemGet could you please also integrate these profiles into our CI builds (see .github/workflow directories) so we may see that they actually work as expected. The necessary builds are: daily, mvn, qulice, integration. This also will show you that -PskipITs and -PskipUTs are not useless)

@ArtemGet
Copy link
Contributor Author

@ArtemGet could you please also integrate these profiles into our CI builds
Sure.

@yegor256
Copy link
Member

@ArtemGet
Copy link
Contributor Author

@maxonfjvipon logs shows that all went fine. Invoker skipped at mvn, surefire skipped at integration and both did not run at qulice check.

@ArtemGet
Copy link
Contributor Author

@ArtemGet please, read this: https://www.yegor256.com/2024/04/01/ping-me-please.html

@yegor256 thanks, just did not want to bother before i make shure all job's logs is fine.

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtemGet LGTM!

@yegor256 yegor256 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into objectionary:master with commit d59b6a1 Dec 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants