Pass active device count. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffy-sam
force-pushed
the
sg-active-count
branch
from
ec1bc7a
to
1cededb
Compare
spiffy-sam
commented
Jul 6, 2023
| @@ -27,7 +27,7 @@ | |||
| <window title="Window" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" animationBehavior="default" id="F0z-JX-Cv5"> | |||
| <windowStyleMask key="styleMask" titled="YES" closable="YES" miniaturizable="YES"/> | |||
| <rect key="contentRect" x="196" y="240" width="600" height="426"/> | |||
| <rect key="screenRect" x="0.0" y="0.0" width="3440" height="1415"/> | |||
| <rect key="screenRect" x="0.0" y="0.0" width="1440" height="875"/> | |||
There was a problem hiding this comment.
I'm not sure what this change is for. I haven't done Xcode xib editing in a while so let me know if I need to revert this part.
When running a script it would be helpful to know if there are still any active devices. This gives the user more information to determine what they want to perform in their script. Example: I want to turn on a smart switch when my camera or mic are active. This switch has a usb 'On Air' light plugged into it. I don't want the light to turn off until all devices are no longer active. The active count allows me to check without having to keep track since Oversight already does this.
spiffy-sam
force-pushed
the
sg-active-count
branch
from
1cededb
to
d079ba2
Compare
objective-see
approved these changes
Oct 26, 2023
timrogers
added a commit
to timrogers/litra
that referenced
this pull request
Nov 21, 2023
…ing `-activeCount` argument `litra-oversight` allows you to automatically turn your Litra on/off when your webcam turns on and off in connection with [OverSight][1]. OverSight can be pointed at the `litra-oversight` command to enable this kind of automation. OverSight calls the specified CLI with a number of arguments. v2.1.8 [added][2] a new `-activeCount` argument that is passed. We don't actually need this or care about it, but since it isn't an allowlisted argument, we error and the integration breaks down. This allows `litra-oversight` to accept but ignore that argument, getting thingss working again. Fixes #259. [1]: https://github.com/objective-see/OverSight [2]: objective-see/OverSight#48
timrogers
added a commit
to timrogers/litra
that referenced
this pull request
Nov 21, 2023
…ing new `-activeCount` argument (#269) * Fix `litra-oversight`'s compatibility with Oversight 2.1.8+ by accepting `-activeCount` argument `litra-oversight` allows you to automatically turn your Litra on/off when your webcam turns on and off in connection with [OverSight][1]. OverSight can be pointed at the `litra-oversight` command to enable this kind of automation. OverSight calls the specified CLI with a number of arguments. v2.1.8 [added][2] a new `-activeCount` argument that is passed. We don't actually need this or care about it, but since it isn't an allowlisted argument, we error and the integration breaks down. This allows `litra-oversight` to accept but ignore that argument, getting thingss working again. Fixes #259. [1]: https://github.com/objective-see/OverSight [2]: objective-see/OverSight#48 * Build TypeScript into JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a script it would be helpful to know if there are still any active devices. This gives the user more information to determine what they want to perform in their script.
Example: I want to turn on a smart switch when my camera or mic are active. This switch has a usb 'On Air' light plugged into it. I don't want the light to turn off until all devices are no longer active. The active count allows me to check without having to keep track since Oversight already does this.
Note: I tried to run this locally but had issues with the Sentry framework. Some instruction on how to build locally would be helpful so I'm not making useless PRs.