Skip to content

Commit

Permalink
v2.2.1: Improved installer, fixed notarization checks
Browse files Browse the repository at this point in the history
Installer (re)activates Finder,
Fixed notarized check (#20)
  • Loading branch information
objective-see committed Jul 7, 2023
1 parent efedb19 commit 5da04d6
Show file tree
Hide file tree
Showing 6 changed files with 276 additions and 15 deletions.
8 changes: 4 additions & 4 deletions Installer/Installer.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@
CODE_SIGN_ENTITLEMENTS = "Installer/WhatsYourSign Installer.entitlements";
CODE_SIGN_IDENTITY = "Developer ID Application";
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
GCC_PREPROCESSOR_DEFINITIONS = (
Expand All @@ -383,7 +383,7 @@
INFOPLIST_FILE = Installer/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSign";
PRODUCT_NAME = "WhatsYourSign Installer";
};
Expand All @@ -396,15 +396,15 @@
CODE_SIGN_ENTITLEMENTS = "Installer/WhatsYourSign Installer.entitlements";
CODE_SIGN_IDENTITY = "Developer ID Application";
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
GCC_PREPROCESSOR_DEFINITIONS = "IS_INSTALLER_APP=1";
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
INFOPLIST_FILE = Installer/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSign";
PRODUCT_NAME = "WhatsYourSign Installer";
};
Expand Down
2 changes: 1 addition & 1 deletion Installer/Installer/patrons.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Patrons (2^6+):
Jan Koum, Nick, Cane Juice, Christian Blümlein, M S, Shain Singh

Friends of Objective-See:
Jamf, Mosyle, Kandji, CleanMyMac X, Kolide, Palo Alto Networks, Addigy, SmugMug, Guardian Mobile Firewall, iVerify, Halo Privacy
Jamf, Mosyle, Kandji, CleanMyMac X, Kolide, Palo Alto Networks, SmugMug, Guardian Mobile Firewall, iVerify, Halo Privacy
2 changes: 1 addition & 1 deletion Shared/utilities.m
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ void restartFinder(void)

//tell Finder to activate
// otherwise it's fully background'd when app exits for some reason!?
//system("osascript -e \"tell application \\\"Finder\\\" to activate\"");
system("osascript -e \"tell application \\\"Finder\\\" to activate\"");

//dbg msg
//logMsg(LOG_DEBUG, @"relaunched Finder.app");
Expand Down
261 changes: 261 additions & 0 deletions WhatsYourSign.xcworkspace/contents.xcworkspacedata

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion WhatsYourSignExt/FinderSync/Signing.m
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ uint32_t bestArchOffset(NSString* path)
}
}
//check notarization status
if(YES == SecStaticCodeCheckValidity(staticCode, kSecCSDefaultFlags, isNotarized))
if(errSecSuccess == SecStaticCodeCheckValidity(staticCode, kSecCSDefaultFlags, isNotarized))
{
//notarized
signingInfo[KEY_SIGNING_IS_NOTARIZED] = [NSNumber numberWithInteger:errSecSuccess];
Expand Down
16 changes: 8 additions & 8 deletions WhatsYourSignExt/WhatsYourSign.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -529,14 +529,14 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Developer ID Application";
CODE_SIGN_STYLE = Manual;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
INFOPLIST_FILE = FinderSync/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @executable_path/../../../../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSignExt.FinderSync";
PRODUCT_NAME = WhatsYourSign;
PROVISIONING_PROFILE = "";
Expand All @@ -553,14 +553,14 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Developer ID Application";
CODE_SIGN_STYLE = Manual;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
INFOPLIST_FILE = FinderSync/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @executable_path/../../../../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSignExt.FinderSync";
PRODUCT_NAME = WhatsYourSign;
PROVISIONING_PROFILE = "";
Expand All @@ -579,13 +579,13 @@
CODE_SIGN_IDENTITY = "Developer ID Application";
CODE_SIGN_STYLE = Manual;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
INFOPLIST_FILE = WhatsYourSignExt/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSign";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
Expand All @@ -603,13 +603,13 @@
CODE_SIGN_IDENTITY = "Developer ID Application";
CODE_SIGN_STYLE = Manual;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 2.2.0;
CURRENT_PROJECT_VERSION = 2.2.1;
DEVELOPMENT_TEAM = VBG97UB4TA;
ENABLE_HARDENED_RUNTIME = YES;
INFOPLIST_FILE = WhatsYourSignExt/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 2.2.0;
MARKETING_VERSION = 2.2.1;
PRODUCT_BUNDLE_IDENTIFIER = "com.objective-see.WhatsYourSign";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
Expand Down

0 comments on commit 5da04d6

Please sign in to comment.