Skip to content

Commit

Permalink
RN-0.73 change Android configs for RN 0.73 compatibility (#600)
Browse files Browse the repository at this point in the history
* RN-0.73 change Android configs for RN 0.73 compatibility

* add back namespace to AndroidManifest

* Update android/build.gradle

Following Sentry implementation to be safer with compatibility https://github.com/getsentry/sentry-react-native/blob/main/android/build.gradle#L17C5-L18C52
  • Loading branch information
FelipeSSantos1 authored Jul 28, 2023
1 parent f3003e8 commit 49756db
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ def safeExtGet(prop, fallback) {
}

android {
// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace = "com.oblador.keychain"
}
compileSdkVersion safeExtGet('compileSdkVersion', 31)
buildToolsVersion safeExtGet('buildToolsVersion', '31.0.0')

Expand Down

0 comments on commit 49756db

Please sign in to comment.