feat: hasGenericPassword #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new function
hasGenericPasswordForOptionsfor both iOS and Android platforms. This function checks if a generic password exists for a given service and returns a Promise.Motivation and Context
In some applications, it's crucial to verify the existence of data in the Keychain (iOS) or Shared Preferences (Android) before attempting to access it (for example when you store encryption key to decrypt the data) This function provides a convenient way to perform this check, similar to the existing
hasInternetCredentialsfunction.Also it should help to solve the issue #135 & #533
We will have a way to determine if the data is in Keychain.
How Has This Been Tested?
Manually tested in a real React Native project on iOS & Android.