-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor and add e2e tests #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Left a few nits and a question around testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there are quite a few cases in this test suite not covered by the e2e from what I can tell. Can we cover them too (esp around which crypto engine picked and migration paths)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about RSA, AES and migration from FB to AES?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! 👍 Once the workflow is complete, I’ll merge it.
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Motivation
This PR introduces end-to-end (e2e) tests to ensure the library functions as expected. The existing Java unit tests were outdated (last updated 3 years ago), only covered Android (with no iOS support), and were difficult to maintain. Due to these issues, I decided to remove the unit tests, as they were no longer helpful and were complicating the development process.
Description
This PR includes the following changes: