fix(ios): build failure when using custom native marks #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build fails on importing `RNPeroformance.h` in Objective-C file, because `chrono` is a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header. `RNPerformanceEntryWasAddedNotification` declaration and initialization were split to prevent build failure as well.
|
Hi, and thanks for your PR! As this doesn't seem to be an issue for myself or others, I'm curious of your setup. Do you use a very old version of React Native? Are you using native markers along with JS based? |
|
Hey, @oblador! No, I use a pretty recent Here's an example based on a clean RN template: https://github.com/hardworker/react-native-performance-test-app |
|
Hey, @oblador. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails on importing
RNPeroformance.hin Objective-C file, becausechronois a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header.RNPerformanceEntryWasAddedNotificationdeclaration and initialization were split to prevent build failure as well.