fix(android): crash when library try to access JSModule before it is initialized #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblador
approved these changes
Mar 8, 2024
|
Thanks for reviewing and merge. Are we going to see new version published soon with this change? |
|
It's published now, wanted to bump React Native, Flipper etc first, but it seems Flipper is pretty broken these days and I gave up for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Crash on Android when using this library #106
To solve this problem, we need to check if ReactContext is initialized.
Ref: https://stackoverflow.com/questions/41120491/react-native-reactcontext-lifecycle-stuck-on-before-create