Ignore iOS prewarming #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #68 the iOS prewarming of apps might caused distorted native launch measurements. We've had similar issues on android where fork time could be days in the past causing weird outliers in RUM that skew avg metrics (which is why I predominantly use median instead of average).
This PR changes the iOS native launch metrics to be based on main() process only, thereby skipping any warmup steps done by the OS to load different system libraries etc. This will inevitably make this duration shorter for super-cold launches, but way less variance – in my testing repeat launches (aka not the first launch after install) give similar number to before.
Curious to get feedback on this change @colinta @opayen @j-piasecki @mikeduminy