-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix borderRadius Android #51
Conversation
Hi @oblador! It seems like to apply this workaround we'd need to add background color prop to avoid the different color in the outline. I'm not sure how to evaluate the magnitude of underlying problem described in react-native/#3198, so I can't make a definite recommendation. Do you think it makes sense to introduce this or is it better to wait for a fix in react-native? Something like:
|
I've patched in the backgroundColorOfParentElement change in an up to date fork. Would you like a new PR for this issue? |
Has there been any progress on this one? @enstulen @pavloko @ddaeschler @oblador |
@AndrewTHuang facing this now, maybe it is not fixed |
Is this still an issue? Appears to be fixed by facebook/react-native@30044fd? |
Closing as I believe it's fixed in RN 0.50 and no replies to the contrary |
Seems like this issue still exists |
Fixes borderRadius on Android. Based on @bsinc's solution facebook/react-native#3198