-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make lintVitalAnalyze*
depend on copy
#1515
fix: make lintVitalAnalyze*
depend on copy
#1515
Conversation
Since Gradle 8 (the default as of React Native 0.72), the task dependency resolution appears to be a lot tighter, and so attempting to run: npx react-native build-android --tasks assembleRelease errors out with the following: - Gradle detected a problem with the following location: '<project>/android/app/build/intermediates/ReactNativeVectorIcons'. Reason: Task ':app:lintVitalAnalyzeRelease' uses this output of task ':app:copyReactNativeVectorIconFonts' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Possible solutions: 1. Declare task ':app:copyReactNativeVectorIconFonts' as an input of ':app:lintVitalAnalyzeRelease'. 2. Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintVitalAnalyzeRelease' using Task#dependsOn. 3. Declare an explicit dependency on ':app:copyReactNativeVectorIconFonts' from ':app:lintVitalAnalyzeRelease' using Task#mustRunAfter. Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. This ensures that any of the `lintVitalAnalyze*` tasks (likely only `lintVitalAnalyzeRelease`) depend on the copy task.
I've only seen this error with
is that |
This probably fixes #1508 |
@oblador is there anything else you'd like to see before considering this PR? |
Thanks for the fix! |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-vector-icons](https://github.com/oblador/react-native-vector-icons) | [`^9.2.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/react-native-vector-icons/9.2.0/10.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-vector-icons (react-native-vector-icons)</summary> ### [`v10.0.0`](https://github.com/oblador/react-native-vector-icons/releases/tag/v10.0.0): 10.0.0 [Compare Source](https://github.com/oblador/react-native-vector-icons/compare/v9.2.0...v10.0.0) #### Overview - Improved support for React Native 0.72, 0.73 and RN Web. - New and updated icon sets. #### Detailed Changes - Fix link to FontAwesome website by [@​nidelson](https://github.com/nidelson) in [https://github.com/oblador/react-native-vector-icons/pull/1444](https://github.com/oblador/react-native-vector-icons/pull/1444) - Upgrade example to React Native 0.70 by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1467](https://github.com/oblador/react-native-vector-icons/pull/1467) - Migrate to new architecture by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1468](https://github.com/oblador/react-native-vector-icons/pull/1468) - Remove setNativeProps by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1469](https://github.com/oblador/react-native-vector-icons/pull/1469) - Upgrade example to React Native 0.72 by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1517](https://github.com/oblador/react-native-vector-icons/pull/1517) - fix: make `lintVitalAnalyze*` depend on copy by [@​msbit](https://github.com/msbit) in [https://github.com/oblador/react-native-vector-icons/pull/1515](https://github.com/oblador/react-native-vector-icons/pull/1515) - Update README.md by [@​aniketjha9179](https://github.com/aniketjha9179) in [https://github.com/oblador/react-native-vector-icons/pull/1502](https://github.com/oblador/react-native-vector-icons/pull/1502) - Update README.md by [@​DaduDev](https://github.com/DaduDev) in [https://github.com/oblador/react-native-vector-icons/pull/1504](https://github.com/oblador/react-native-vector-icons/pull/1504) - Fix to get working with react-native-web by [@​johnf](https://github.com/johnf) in [https://github.com/oblador/react-native-vector-icons/pull/1492](https://github.com/oblador/react-native-vector-icons/pull/1492) - RN-0.73 change Android configs for RN 0.73 compatibility by [@​felipemillhouse](https://github.com/felipemillhouse) in [https://github.com/oblador/react-native-vector-icons/pull/1507](https://github.com/oblador/react-native-vector-icons/pull/1507) - Replace tabBarOptions with screenOptions by [@​MenaiAla](https://github.com/MenaiAla) in [https://github.com/oblador/react-native-vector-icons/pull/1478](https://github.com/oblador/react-native-vector-icons/pull/1478) - fix (ios): support kCTFontManagerErrorDuplicatedName as allowable error by [@​iBotPeaches](https://github.com/iBotPeaches) in [https://github.com/oblador/react-native-vector-icons/pull/1474](https://github.com/oblador/react-native-vector-icons/pull/1474) - Update README with monorepo info for Android by [@​samzmann](https://github.com/samzmann) in [https://github.com/oblador/react-native-vector-icons/pull/1476](https://github.com/oblador/react-native-vector-icons/pull/1476) - Improve Error Logging for Font Imports by [@​JKeddo95](https://github.com/JKeddo95) in [https://github.com/oblador/react-native-vector-icons/pull/1475](https://github.com/oblador/react-native-vector-icons/pull/1475) - Update Ionicons to v7.1.0 by [@​mrkpatchaa](https://github.com/mrkpatchaa) in [https://github.com/oblador/react-native-vector-icons/pull/1484](https://github.com/oblador/react-native-vector-icons/pull/1484) - Fontawesome6 (Closes [#​1408](https://github.com/oblador/react-native-vector-icons/issues/1408)) by [@​johnf](https://github.com/johnf) in [https://github.com/oblador/react-native-vector-icons/pull/1483](https://github.com/oblador/react-native-vector-icons/pull/1483) - Use Node 16 in CI by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1518](https://github.com/oblador/react-native-vector-icons/pull/1518) - Upgrade Material Icons to Sept 2022 update by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1519](https://github.com/oblador/react-native-vector-icons/pull/1519) - Move ionicon build dependencies to devDependencies by [@​oblador](https://github.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1520](https://github.com/oblador/react-native-vector-icons/pull/1520) #### New Contributors - [@​nidelson](https://github.com/nidelson) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1444](https://github.com/oblador/react-native-vector-icons/pull/1444) - [@​msbit](https://github.com/msbit) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1515](https://github.com/oblador/react-native-vector-icons/pull/1515) - [@​aniketjha9179](https://github.com/aniketjha9179) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1502](https://github.com/oblador/react-native-vector-icons/pull/1502) - [@​DaduDev](https://github.com/DaduDev) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1504](https://github.com/oblador/react-native-vector-icons/pull/1504) - [@​johnf](https://github.com/johnf) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1492](https://github.com/oblador/react-native-vector-icons/pull/1492) - [@​felipemillhouse](https://github.com/felipemillhouse) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1507](https://github.com/oblador/react-native-vector-icons/pull/1507) - [@​MenaiAla](https://github.com/MenaiAla) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1478](https://github.com/oblador/react-native-vector-icons/pull/1478) - [@​iBotPeaches](https://github.com/iBotPeaches) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1474](https://github.com/oblador/react-native-vector-icons/pull/1474) - [@​samzmann](https://github.com/samzmann) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1476](https://github.com/oblador/react-native-vector-icons/pull/1476) - [@​JKeddo95](https://github.com/JKeddo95) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1475](https://github.com/oblador/react-native-vector-icons/pull/1475) - [@​mrkpatchaa](https://github.com/mrkpatchaa) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1484](https://github.com/oblador/react-native-vector-icons/pull/1484) **Full Changelog**: oblador/react-native-vector-icons@v9.2.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Since Gradle 8 (the default as of React Native 0.72), the task dependency resolution appears to be a lot tighter, and so attempting to run:
errors out with the following:
This ensures that any of the
lintVitalAnalyze*
tasks (likely onlylintVitalAnalyzeRelease
) depend on the copy task.