Add list of all fonts to copy & paste in the info.plist file #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add list of all fonts to copy & paste in the info.plist file
sturmenta
changed the title
|
In most cases you don't want to have all fonts in your bundle as it bloats the size of your app. Maybe change the wording a bit saying these are "all available" fonts or something like this? |
oblador
approved these changes
Mar 11, 2019
|
@oblador I already made that change in the text |
|
Thanks! |
|
Thanks to you! |
ratson
pushed a commit
to ratson/react-native-vector-icons
that referenced
this pull request
Apr 24, 2019
…#957) * Update README.md Add list of all fonts to copy & paste in the info.plist file * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add list of all fonts to copy & paste in the info.plist file