Encode type before header, simplify access to pixel data #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write encode type to the second pixel in the encoding sequence as raw bits (just as with BPC) before the fully encoded header. This allows automatic detection of the encoding type by the decoder and greater flexibility for future encoding strategies, given that all reading/ writing procedures after reading the first two pixels can be implemented differently based on the type value. Use PxAccessRead and PxAccessWrite to greatly simplify argument passing and initialization of pixel reading/writing facilities, as well as automatically handle reading/writing the first two meta pixels (BPC & Encoding Type). Also adds a couple tests that check for proper operation when filling a medium near to or at full capacity, where dropped data or heap corruption is a concern if pixel access is improperly designed
oblivioncth
force-pushed
the
in_stream_type_info
branch
from
7d1ba65
to
a24bd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write encode type to the second pixel in the encoding sequence as raw
bits (just as with BPC) before the fully encoded header. This allows
automatic detection of the encoding type by the decoder and greater
flexibility for future encoding strategies, given that all reading/
writing procedures after reading the first two pixels can be implemented
differently based on the type value.
Use PxAccessRead and PxAccessWrite to greatly simplify argument passing
and initialization of pixel reading/writing facilities, as well as
automatically handle reading/writing the first two meta pixels (BPC &
Encoding Type).
Also adds a couple tests that check for proper operation when filling a
medium near to or at full capacity, where dropped data or heap
corruption is a concern if pixel access is improperly designed