Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove reliance on hosted swapi #1119

Merged
merged 1 commit into from
Dec 31, 2024
Merged

chore: remove reliance on hosted swapi #1119

merged 1 commit into from
Dec 31, 2024

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Dec 30, 2024

The hosted swapi GraphQL endpoint doesn't seem to be working at the moment, and it's causing all the tests to fail. Not ideal.

This adds a graphql-mocks crate (ported & simplified from an implementation in the grafbase repo - probably not the cleanest since I did the port quick n dirty, but it works) and updates the tests to use that.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit e3267f7
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/6773fc304a5816000835f0b0

@obmarg obmarg force-pushed the obmarg/qpuuyxxurmwp branch 3 times, most recently from d487e94 to f4be9af Compare December 31, 2024 14:02
The hosted swapi GraphQL endpoint doesn't seem to be working at the
moment, and it's causing all the tests to fail.  Not ideal.

This adds a graphql-mocks crate (ported & simplified from an
implementation in the grafbase repo - probably not the cleanest since I
did the port quick n dirty, but it works) and updates the tests to use
that
@obmarg obmarg force-pushed the obmarg/qpuuyxxurmwp branch from f4be9af to e3267f7 Compare December 31, 2024 14:14
@obmarg obmarg merged commit 2c80a85 into main Dec 31, 2024
6 checks passed
@obmarg obmarg deleted the obmarg/qpuuyxxurmwp branch December 31, 2024 14:19
@cynic-releaser cynic-releaser bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant