-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre Release 2022 03 25 FIXES #2364
Conversation
Changing `subcapsular sinus of lymph node ceiling` and `subcapsular sinus floor` to anatomical space instead of organ part, as they are both part of anatomical spaces. cc @paolaroncaglia @shawntanzk @dosumis to
@sbello you are a star thank you! Can you suggest a better relationship to use then? I am not really versed on these anatomy relations.. |
Given that the sinus = space I don't know that there is an adequate way to relate the ceiling to the space. Even assuming adjacent_to can be used between a material and immaterial entity it loses that this is the top portion and we will probably need to enter a term for the floor at some point. |
@shawntanzk @dosumis @cmungall Release is blocked until someone can respond to @sbello who prevented me from committing some hasty fix :) Please advice. |
- getting rid of a lot of the import makefile customisation
provisional fix to #2367 cc @shawntanzk
Remove part_of neck from jugular vein
subcapsular sinus floor and ceiling fix
…uberon into release-2022-03-25
We will go the minimal route, closing this in favour of a clean PR: https://github.com/obophenotype/uberon/pull/2376/files |
Under construction
Some errors slipped into Uberon due to missing QC, and had to be fixed first. The QC is part of @cmungall old battery of tests which I am introducing when I am done fixing.
Blocked by