Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre Release 2022 03 25 FIXES #2364

Closed
wants to merge 36 commits into from
Closed

Pre Release 2022 03 25 FIXES #2364

wants to merge 36 commits into from

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 25, 2022

Under construction

Some errors slipped into Uberon due to missing QC, and had to be fixed first. The QC is part of @cmungall old battery of tests which I am introducing when I am done fixing.

Blocked by

Changing

`subcapsular sinus of lymph node ceiling` and `subcapsular sinus floor`

to anatomical space instead of organ part, as they are both part of anatomical spaces.

cc @paolaroncaglia @shawntanzk @dosumis

to
@matentzn
Copy link
Contributor Author

@sbello you are a star thank you! Can you suggest a better relationship to use then? I am not really versed on these anatomy relations..

@sbello
Copy link

sbello commented Mar 25, 2022

Given that the sinus = space I don't know that there is an adequate way to relate the ceiling to the space. Even assuming adjacent_to can be used between a material and immaterial entity it loses that this is the top portion and we will probably need to enter a term for the floor at some point.
You can say that this is part_of the lymph node, that much is accurate.
Note there is inconsistency in Uberon as to whether X sinus refers to the space or the tissue surrounding the space. This is probably due to the way biologists name things but it does make finding relevant examples tricky.
Sorry not to give you a definite answer.

@matentzn
Copy link
Contributor Author

@shawntanzk @dosumis @cmungall Release is blocked until someone can respond to @sbello who prevented me from committing some hasty fix :) Please advice.

- getting rid of a lot of the import makefile customisation
@matentzn
Copy link
Contributor Author

matentzn commented Apr 1, 2022

We will go the minimal route, closing this in favour of a clean PR: https://github.com/obophenotype/uberon/pull/2376/files

@matentzn matentzn closed this Apr 1, 2022
@anitacaron anitacaron deleted the release-2022-03-25 branch February 10, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants