Updating pro import #2413
Updating pro import #2413
Conversation
|
I provided an ODK fix.. We should prioritise moving Uberon to base module system.. |
|
@matentzn the PRO-short-label is still there in this branch |
| <!-- http://purl.obolibrary.org/obo/pr#PRO-common-name --> | ||
|
|
||
| <owl:AnnotationProperty rdf:about="http://purl.obolibrary.org/obo/pr#PRO-common-name"> | ||
| <rdfs:subPropertyOf rdf:resource="http://www.geneontology.org/formats/oboInOwl#SynonymTypeProperty"/> |
There was a problem hiding this comment.
This is the key row @shawntanzk
If you run sh run.sh make uberon.obo IMP=false PAT=false BRI=false the subsets should look correct.
|
@shawntanzk How did you verify this? I checked the source, and it looks correct (I also tagged you on the line so you can see it) |
Oh I thought you wanted to remove it, I just checked in protege if it was still there. But I see that you changed it to a has_synonym_type AP |
|
I dont know whether I ever explained the problem to you: Basically OBO format has this thing where it expects synonym types and subsets to be sub-annotation-properties of some specific parent. But the ROBOT module extraction process does not know about that - and |
|
btws is this ready to merge? also do we have to do a release for this? |
|
Yeah, lets do another release on Friday. It will be easier now. |
|
Sure, merge |
Fixes #2373
@matentzn - doesnt seem to fix after updating pro -> not sure if it got updated right? (I update mirror and all) could you help me check if the diff has the changes?