Created general_subset, to replace CARO ontology #2614
Conversation
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsacellular anatomical structure
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsacellular anatomical structure
|
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
@cmungall what do you mean by "conflation" in this context? Conflating animal/plant/fungal structures into single classes? |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
@dosumis will merge this when he is in Berkely mid December. |
We'll see :) |
|
[it's already accruing conflicts...] I am in favor of this, we should communicate these plans more broadly though, esp to FAO and PO. Is the best way to do this to edit the initial comment in #2349 to word more clearly as a specific proposal? |
|
Subset name suggestion from @cmungall: |
Added taxonomic scope statement.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
|
Thanks for updating @anitacaron. I will try to make some time to update this PR to change the subset name to |
|
@anitacaron I think this is ready to merge, assuming the tests pass. |
Related to #2349
I created a
general_subsetcontaining terms that must be applicable outside of Metazoa. I'm open to suggestions for an alternative name for the subset. For all these terms, I added present_in_taxon annotations:Hopefully these will help catch unwanted taxonomic specificity connected to these terms.
This PR also updates the taxon import to include Fungi.