Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022-08-16 release #2615

Closed
wants to merge 8 commits into from
Closed

2022-08-16 release #2615

wants to merge 8 commits into from

Conversation

shawntanzk
Copy link
Collaborator

No description provided.

@shawntanzk shawntanzk self-assigned this Aug 16, 2022
@anitacaron
Copy link
Collaborator

I checked that never_in_taxon properties are back!

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive release:

  • remove renal-minimal files from version control with git rm. Make sure they are in .gitignore.
  • Check uberon.owl for dangling classes, there seem to be hundreds of removed terms in our imports

<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002405"/>
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002416"/>
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002423"/>
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0004456"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of disjointnesses remove, intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvarner-ebi & @nicolevasilevsky - I assume this is the work you guys did with the renal system stuff? could you check this please

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawntanzk, sorry, these do not look familiar.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @balhoff - ignore that, was looking at the wrong thing >.<

@shawntanzk
Copy link
Collaborator Author

strange that the renal-minimal files got through, there is already this in .gitignore:

subsets/*.json
subsets/*.obo
subsets/*.owl
subsets/*.tsv

@shawntanzk
Copy link
Collaborator Author

Check uberon.owl for dangling classes, there seem to be hundreds of removed terms in our imports

hmmm this isn't good, there is indeed a whole bunch of ncbitaxon dangling - which I assume match the ncbi imports that were being removed in this release - any ideas why?
Screenshot 2022-08-17 at 09 56 02

@anitacaron
Copy link
Collaborator

I saw in uberon.obo that some of the NCBITaxon class definitions were deleted but still have the relationship present_in_taxon.

@matentzn
Copy link
Contributor

Anita my guess is: never in taxon are somehow not read by seed extraction process. Don't know why it ever worked..

@anitacaron
Copy link
Collaborator

But all classes in the image are used with only_in_taxon and present_in_taxon.

@matentzn
Copy link
Contributor

Can someone verify that http://purl.obolibrary.org/obo/ncbitaxon/subsets/taxslim.owl contains all of these IDs now dangling?

@anitacaron
Copy link
Collaborator

It doesn't contain any of these terms.

@matentzn
Copy link
Contributor

Can you make a PR here: https://github.com/obophenotype/ncbitaxon/blob/master/subsets/taxon-subset-ids.txt to get them in and assign me?

We will drive fast to get this resolved

@matentzn
Copy link
Contributor

While we are working on this - are all the other dangling classes expected?

@shawntanzk
Copy link
Collaborator Author

While we are working on this - are all the other dangling classes expected?

1 GO term (http://purl.obolibrary.org/obo/GO_0097254) that should not be dangling

4 CARO terms:
Screenshot 2022-08-17 at 13 20 26

http://purl.obolibrary.org/obo/RnorDv_0000010 -> not sure what this is

@matentzn
Copy link
Contributor

Caro seems to be a proper import of uberon, but not included in the edit file. @shawntanzk can you try to add the caro import to the edit file and see if this breaks the uberon release?

@matentzn
Copy link
Contributor

Whats the usage of teh GO dangler?

@shawntanzk
Copy link
Collaborator Author

Whats the usage of teh GO dangler?

Screenshot 2022-08-17 at 13 33 02

@shawntanzk
Copy link
Collaborator Author

@shawntanzk can you try to add the caro import to the edit file and see if this breaks the uberon release?

on edit file seems to work fine - have not built the release file - happy to fix the danglers and make uberon if you arent already doing it?

@matentzn
Copy link
Contributor

No I am not working on it

@matentzn
Copy link
Contributor

Ok try refrshig imports https://github.com/obophenotype/ncbitaxon/releases/tag/v2022-08-17

@shawntanzk
Copy link
Collaborator Author

@shawntanzk
Copy link
Collaborator Author

Ok try refrshig imports https://github.com/obophenotype/ncbitaxon/releases/tag/v2022-08-17

Tried refreshing all imports, no change
Tried updating mirror for ncbitaxon then refreshing ncbitaxon_import.owl, no change
Tried adding the missing terms to ncbitaxon_import.txt and refreshing ncbitaxon_import.owl, no change :(

@shawntanzk
Copy link
Collaborator Author

Just saw the NCBITaxon tagged as pre-release instead of latest - could this be the problem?

@shawntanzk
Copy link
Collaborator Author

Looks like the issue was brought in with the reinstatement of CARO as an import - maybe why it was removed before?

@matentzn
Copy link
Contributor

Excellent this exact query should be a GitHub action, which if it fails, posts the unsat as a comment to the PR. Wouldnt this be awesome?

And lucking at this query, while being tired and annoyed, can't help you feel amazed by the awesomeness of the tech for this particular use case. No other stack can do that. Finding an inconsistency like that.

@matentzn
Copy link
Contributor

Not sure man this unsat looks pretty legit to me. Removing caro would just hide an inconsistency!

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-17/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-17/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

IAO_0000589 http://purl.obolibrary.org/obo/IAO_0000589

Added

RO_0002575 http://purl.obolibrary.org/obo/RO_0002575

Added

adjacent_to http://purl.obolibrary.org/obo/RO_0002220

Added

attached to part of http://purl.obolibrary.org/obo/RO_0002177

Added

attaches_to http://purl.obolibrary.org/obo/RO_0002371

Added

bounding layer of http://purl.obolibrary.org/obo/RO_0002007

Added

branching part of http://purl.obolibrary.org/obo/RO_0002380

Added

capable of part of http://purl.obolibrary.org/obo/RO_0002216

Added

citesAsAuthority http://purl.org/spar/cito/citesAsAuthority

Added

composed primarily of http://purl.obolibrary.org/obo/RO_0002473

Added

confers advantage in http://purl.obolibrary.org/obo/RO_0002322

Added

  • confers advantage in IAO_0000118 "adapted for"

  • confers advantage in IAO_0000117 "Chris Mungall"

  • confers advantage in editor note "An experimental relation currently used to connect a feature possessed by an organism (e.g. anatomical structure, biological process, phenotype or quality) to a habitat or environment in which that feature is well suited, adapted or provides a reproductive advantage for the organism. For example, fins to an aquatic environment. Usually this will mean that the structure is adapted for this environment, but we avoid saying this directly - primitive forms of the structure may not have evolved specifically for that environment (for example, early wings were not necessarily adapted for an aerial environment). Note also that this is a statement about the general class of structures - not every instance of a limb need confer an advantage for a terrestrial environment, e.g. if the limb is vestigial."

  • confers advantage in in_subset ro-eco

connected to http://purl.obolibrary.org/obo/RO_0002170

Added

connects http://purl.obolibrary.org/obo/RO_0002176

Added

contains http://purl.obolibrary.org/obo/RO_0001019

Added

continuous with http://purl.obolibrary.org/obo/RO_0002150

Added

contributes to morphology of http://purl.obolibrary.org/obo/RO_0002433

Added

developmentally replaces http://purl.obolibrary.org/obo/RO_0002285

Added

developmentally_induced_by http://purl.obolibrary.org/obo/RO_0002256

Added

develops from part of http://purl.obolibrary.org/obo/RO_0002225

Added

develops in http://purl.obolibrary.org/obo/RO_0002226

Added

directly develops from http://purl.obolibrary.org/obo/RO_0002207

Added

drains http://purl.obolibrary.org/obo/RO_0002179

Added

  • drains editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between a vein and an anatomical structure"

  • drains IAO_0000119 20064205

ends http://purl.obolibrary.org/obo/RO_0002229

Added

ends with http://purl.obolibrary.org/obo/RO_0002230

Added

existence ends during http://purl.obolibrary.org/obo/RO_0002492

Added

existence ends during or before http://purl.obolibrary.org/obo/RO_0002497

Added

existence ends with http://purl.obolibrary.org/obo/RO_0002493

Added

  • existence ends with IAO_0000117 "Chris Mungall"

  • existence ends with comment "The relations here were created based on work originally by Fabian Neuhaus and David Osumi-Sutherland. The work has not yet been vetted and errors in definitions may have occurred during transcription."

existence starts and ends during http://purl.obolibrary.org/obo/RO_0002491

Added

existence starts during http://purl.obolibrary.org/obo/RO_0002488

Added

existence starts during or after http://purl.obolibrary.org/obo/RO_0002496

Added

existence starts with http://purl.obolibrary.org/obo/RO_0002489

Added

has 2D boundary http://purl.obolibrary.org/obo/RO_0002002

Added

has branching part http://purl.obolibrary.org/obo/RO_0002569

Added

has component http://purl.obolibrary.org/obo/RO_0002180

Added

has member http://purl.obolibrary.org/obo/RO_0002351

Added

has muscle antagonist http://purl.obolibrary.org/obo/RO_0002568

Added

has muscle insertion http://purl.obolibrary.org/obo/RO_0002373

Added

has muscle origin http://purl.obolibrary.org/obo/RO_0002372

Added

has skeleton http://purl.obolibrary.org/obo/RO_0002551

Added

has_part http://purl.obolibrary.org/obo/BFO_0000051

Added

immediate transformation of http://purl.obolibrary.org/obo/RO_0002495

Added

immediately preceded by http://purl.obolibrary.org/obo/RO_0002087

Added

in taxon http://purl.obolibrary.org/obo/RO_0002162

Added

innervated_by http://purl.obolibrary.org/obo/RO_0002005

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Added

located in http://purl.obolibrary.org/obo/RO_0001025

Added

location of http://purl.obolibrary.org/obo/RO_0001015

Added

lumen of http://purl.obolibrary.org/obo/RO_0002571

Added

luminal space of http://purl.obolibrary.org/obo/RO_0002572

Added

only_in_taxon http://purl.obolibrary.org/obo/RO_0002160

Added

'in taxon' some Eukaryota DisjointWith 'in taxon' some Eubacteria"

output of http://purl.obolibrary.org/obo/RO_0002353

Added

overlaps http://purl.obolibrary.org/obo/RO_0002131

Added

part_of http://purl.obolibrary.org/obo/BFO_0000050

Added

participates in http://purl.obolibrary.org/obo/RO_0000056

Added

preceded_by http://purl.obolibrary.org/obo/BFO_0000062

Added

precedes http://purl.obolibrary.org/obo/BFO_0000063

Added

present in taxon http://purl.obolibrary.org/obo/RO_0002175

Added

  • present in taxon comment "The SPARQL expansion for this relation introduces new named classes into the ontology. For this reason it is likely that the expansion should only be performed during a QC pipeline; the expanded output should usually not be included in a published version of the ontology."

produced_by http://purl.obolibrary.org/obo/RO_0003001

Added

produces http://purl.obolibrary.org/obo/RO_0003000

Added

simultaneous with http://purl.obolibrary.org/obo/RO_0002082

Added

skeleton of http://purl.obolibrary.org/obo/RO_0002576

Added

starts http://purl.obolibrary.org/obo/RO_0002223

Added

starts with http://purl.obolibrary.org/obo/RO_0002224

Added

supplies http://purl.obolibrary.org/obo/RO_0002178

Added

  • supplies editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between an artery and an anatomical structure"

  • supplies IAO_0000119 20064205

surrounded by http://purl.obolibrary.org/obo/RO_0002219

Added

surrounds http://purl.obolibrary.org/obo/RO_0002221

Added

transformation of http://purl.obolibrary.org/obo/RO_0002494

Added

tributary_of http://purl.obolibrary.org/obo/RO_0002376

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Added

Ontology annotations

@shawntanzk
Copy link
Collaborator Author

Unsat related to #2589
Fix - change innervate to 'extends_fibers_into'

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

IAO_0000589 http://purl.obolibrary.org/obo/IAO_0000589

Added

RO_0002575 http://purl.obolibrary.org/obo/RO_0002575

Added

adjacent_to http://purl.obolibrary.org/obo/RO_0002220

Added

attached to http://purl.obolibrary.org/obo/RO_0002371

Added

attached to part of http://purl.obolibrary.org/obo/RO_0002177

Added

bounding layer of http://purl.obolibrary.org/obo/RO_0002007

Added

branching part of http://purl.obolibrary.org/obo/RO_0002380

Added

capable of part of http://purl.obolibrary.org/obo/RO_0002216

Added

citesAsAuthority http://purl.org/spar/cito/citesAsAuthority

Added

composed primarily of http://purl.obolibrary.org/obo/RO_0002473

Added

confers advantage in http://purl.obolibrary.org/obo/RO_0002322

Added

  • confers advantage in IAO_0000118 "adapted for"

  • confers advantage in IAO_0000117 "Chris Mungall"

  • confers advantage in editor note "An experimental relation currently used to connect a feature possessed by an organism (e.g. anatomical structure, biological process, phenotype or quality) to a habitat or environment in which that feature is well suited, adapted or provides a reproductive advantage for the organism. For example, fins to an aquatic environment. Usually this will mean that the structure is adapted for this environment, but we avoid saying this directly - primitive forms of the structure may not have evolved specifically for that environment (for example, early wings were not necessarily adapted for an aerial environment). Note also that this is a statement about the general class of structures - not every instance of a limb need confer an advantage for a terrestrial environment, e.g. if the limb is vestigial."

  • confers advantage in in_subset ro-eco

connected to http://purl.obolibrary.org/obo/RO_0002170

Added

connects http://purl.obolibrary.org/obo/RO_0002176

Added

contains http://purl.obolibrary.org/obo/RO_0001019

Added

continuous_with http://purl.obolibrary.org/obo/RO_0002150

Added

contributes to morphology of http://purl.obolibrary.org/obo/RO_0002433

Added

developmentally_induced_by http://purl.obolibrary.org/obo/RO_0002256

Added

developmentally_replaces http://purl.obolibrary.org/obo/RO_0002285

Added

develops from part of http://purl.obolibrary.org/obo/RO_0002225

Added

develops in http://purl.obolibrary.org/obo/RO_0002226

Added

directly develops from http://purl.obolibrary.org/obo/RO_0002207

Added

drains http://purl.obolibrary.org/obo/RO_0002179

Added

  • drains editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between a vein and an anatomical structure"

  • drains IAO_0000119 20064205

ends http://purl.obolibrary.org/obo/RO_0002229

Added

ends with http://purl.obolibrary.org/obo/RO_0002230

Added

existence ends during http://purl.obolibrary.org/obo/RO_0002492

Added

existence ends during or before http://purl.obolibrary.org/obo/RO_0002497

Added

existence ends with http://purl.obolibrary.org/obo/RO_0002493

Added

  • existence ends with IAO_0000117 "Chris Mungall"

  • existence ends with comment "The relations here were created based on work originally by Fabian Neuhaus and David Osumi-Sutherland. The work has not yet been vetted and errors in definitions may have occurred during transcription."

existence starts and ends during http://purl.obolibrary.org/obo/RO_0002491

Added

existence starts during http://purl.obolibrary.org/obo/RO_0002488

Added

existence starts during or after http://purl.obolibrary.org/obo/RO_0002496

Added

existence starts with http://purl.obolibrary.org/obo/RO_0002489

Added

has 2D boundary http://purl.obolibrary.org/obo/RO_0002002

Added

has branching part http://purl.obolibrary.org/obo/RO_0002569

Added

has component http://purl.obolibrary.org/obo/RO_0002180

Added

has member http://purl.obolibrary.org/obo/RO_0002351

Added

has muscle antagonist http://purl.obolibrary.org/obo/RO_0002568

Added

has muscle insertion http://purl.obolibrary.org/obo/RO_0002373

Added

has muscle origin http://purl.obolibrary.org/obo/RO_0002372

Added

has skeleton http://purl.obolibrary.org/obo/RO_0002551

Added

has_part http://purl.obolibrary.org/obo/BFO_0000051

Added

immediate transformation of http://purl.obolibrary.org/obo/RO_0002495

Added

immediately preceded by http://purl.obolibrary.org/obo/RO_0002087

Added

in taxon http://purl.obolibrary.org/obo/RO_0002162

Added

innervated_by http://purl.obolibrary.org/obo/RO_0002005

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Added

located in http://purl.obolibrary.org/obo/RO_0001025

Added

location of http://purl.obolibrary.org/obo/RO_0001015

Added

lumen of http://purl.obolibrary.org/obo/RO_0002571

Added

luminal space of http://purl.obolibrary.org/obo/RO_0002572

Added

only_in_taxon http://purl.obolibrary.org/obo/RO_0002160

Added

'in taxon' some Eukaryota DisjointWith 'in taxon' some Eubacteria"

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

output of http://purl.obolibrary.org/obo/RO_0002353

Added

overlaps http://purl.obolibrary.org/obo/RO_0002131

Added

part_of http://purl.obolibrary.org/obo/BFO_0000050

Added

participates in http://purl.obolibrary.org/obo/RO_0000056

Added

preceded_by http://purl.obolibrary.org/obo/BFO_0000062

Added

precedes http://purl.obolibrary.org/obo/BFO_0000063

Added

present_in_taxon http://purl.obolibrary.org/obo/RO_0002175

Added

  • present_in_taxon comment "The SPARQL expansion for this relation introduces new named classes into the ontology. For this reason it is likely that the expansion should only be performed during a QC pipeline; the expanded output should usually not be included in a published version of the ontology."

produced_by http://purl.obolibrary.org/obo/RO_0003001

Added

produces http://purl.obolibrary.org/obo/RO_0003000

Added

simultaneous with http://purl.obolibrary.org/obo/RO_0002082

Added

skeleton of http://purl.obolibrary.org/obo/RO_0002576

Added

starts http://purl.obolibrary.org/obo/RO_0002223

Added

starts with http://purl.obolibrary.org/obo/RO_0002224

Added

supplies http://purl.obolibrary.org/obo/RO_0002178

Added

  • supplies editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between an artery and an anatomical structure"

  • supplies IAO_0000119 20064205

surrounded by http://purl.obolibrary.org/obo/RO_0002219

Added

surrounds http://purl.obolibrary.org/obo/RO_0002221

Added

transformation of http://purl.obolibrary.org/obo/RO_0002494

Added

tributary_of http://purl.obolibrary.org/obo/RO_0002376

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Added

Ontology annotations

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

@matentzn
Copy link
Contributor

@shawntanzk
Copy link
Collaborator Author

More unsat funtimes :')

From:

% robot --catalog catalog-v001.xml explain -i tmp/uberon-edit-plus-tax-equivs.owl -M unsatisfiability --unsatisfiable random:10 --explanation unsat.md

AAO_0010670 SubClassOf Nothing

AAO_0010470 SubClassOf Nothing

AAO_0010730 SubClassOf Nothing

AAO_0010688 SubClassOf Nothing

AAO_0010648 SubClassOf Nothing

AAO_0010632 SubClassOf Nothing

AAO_0000194 SubClassOf Nothing

AAO_0000298 SubClassOf Nothing

AAO_0010628 SubClassOf Nothing

AAO_0010703 SubClassOf Nothing

Axiom Impact

Axioms used 10 times

Axioms used 8 times

Axioms used 7 times

Axioms used 4 times

Axioms used 2 times

Axioms used 1 times

Ontologies used:

@shawntanzk
Copy link
Collaborator Author

seems like it all leads back to multi-cell-part structure DisjointWith multicellular anatomical structure again

@matentzn
Copy link
Contributor

Can you remove the disjointness axiom and see if that gets the release to run through?

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

IAO_0000589 http://purl.obolibrary.org/obo/IAO_0000589

Added

RO_0002575 http://purl.obolibrary.org/obo/RO_0002575

Added

adjacent_to http://purl.obolibrary.org/obo/RO_0002220

Added

attached to http://purl.obolibrary.org/obo/RO_0002371

Added

attached to part of http://purl.obolibrary.org/obo/RO_0002177

Added

bounding layer of http://purl.obolibrary.org/obo/RO_0002007

Added

branching part of http://purl.obolibrary.org/obo/RO_0002380

Added

capable of part of http://purl.obolibrary.org/obo/RO_0002216

Added

citesAsAuthority http://purl.org/spar/cito/citesAsAuthority

Added

composed primarily of http://purl.obolibrary.org/obo/RO_0002473

Added

confers advantage in http://purl.obolibrary.org/obo/RO_0002322

Added

  • confers advantage in IAO_0000118 "adapted for"

  • confers advantage in IAO_0000117 "Chris Mungall"

  • confers advantage in editor note "An experimental relation currently used to connect a feature possessed by an organism (e.g. anatomical structure, biological process, phenotype or quality) to a habitat or environment in which that feature is well suited, adapted or provides a reproductive advantage for the organism. For example, fins to an aquatic environment. Usually this will mean that the structure is adapted for this environment, but we avoid saying this directly - primitive forms of the structure may not have evolved specifically for that environment (for example, early wings were not necessarily adapted for an aerial environment). Note also that this is a statement about the general class of structures - not every instance of a limb need confer an advantage for a terrestrial environment, e.g. if the limb is vestigial."

  • confers advantage in in_subset ro-eco

connected to http://purl.obolibrary.org/obo/RO_0002170

Added

connects http://purl.obolibrary.org/obo/RO_0002176

Added

contains http://purl.obolibrary.org/obo/RO_0001019

Added

continuous_with http://purl.obolibrary.org/obo/RO_0002150

Added

contributes to morphology of http://purl.obolibrary.org/obo/RO_0002433

Added

developmentally_induced_by http://purl.obolibrary.org/obo/RO_0002256

Added

developmentally_replaces http://purl.obolibrary.org/obo/RO_0002285

Added

develops from part of http://purl.obolibrary.org/obo/RO_0002225

Added

develops in http://purl.obolibrary.org/obo/RO_0002226

Added

directly develops from http://purl.obolibrary.org/obo/RO_0002207

Added

drains http://purl.obolibrary.org/obo/RO_0002179

Added

  • drains editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between a vein and an anatomical structure"

  • drains IAO_0000119 20064205

ends http://purl.obolibrary.org/obo/RO_0002229

Added

ends with http://purl.obolibrary.org/obo/RO_0002230

Added

existence ends during http://purl.obolibrary.org/obo/RO_0002492

Added

existence ends during or before http://purl.obolibrary.org/obo/RO_0002497

Added

existence ends with http://purl.obolibrary.org/obo/RO_0002493

Added

  • existence ends with IAO_0000117 "Chris Mungall"

  • existence ends with comment "The relations here were created based on work originally by Fabian Neuhaus and David Osumi-Sutherland. The work has not yet been vetted and errors in definitions may have occurred during transcription."

existence starts and ends during http://purl.obolibrary.org/obo/RO_0002491

Added

existence starts during http://purl.obolibrary.org/obo/RO_0002488

Added

existence starts during or after http://purl.obolibrary.org/obo/RO_0002496

Added

existence starts with http://purl.obolibrary.org/obo/RO_0002489

Added

has 2D boundary http://purl.obolibrary.org/obo/RO_0002002

Added

has branching part http://purl.obolibrary.org/obo/RO_0002569

Added

has component http://purl.obolibrary.org/obo/RO_0002180

Added

has member http://purl.obolibrary.org/obo/RO_0002351

Added

has muscle antagonist http://purl.obolibrary.org/obo/RO_0002568

Added

has muscle insertion http://purl.obolibrary.org/obo/RO_0002373

Added

has muscle origin http://purl.obolibrary.org/obo/RO_0002372

Added

has skeleton http://purl.obolibrary.org/obo/RO_0002551

Added

has_part http://purl.obolibrary.org/obo/BFO_0000051

Added

immediate transformation of http://purl.obolibrary.org/obo/RO_0002495

Added

immediately preceded by http://purl.obolibrary.org/obo/RO_0002087

Added

in taxon http://purl.obolibrary.org/obo/RO_0002162

Added

innervated_by http://purl.obolibrary.org/obo/RO_0002005

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Added

located in http://purl.obolibrary.org/obo/RO_0001025

Added

location of http://purl.obolibrary.org/obo/RO_0001015

Added

lumen of http://purl.obolibrary.org/obo/RO_0002571

Added

luminal space of http://purl.obolibrary.org/obo/RO_0002572

Added

only in taxon http://purl.obolibrary.org/obo/RO_0002160

Added

'in taxon' some Eukaryota DisjointWith 'in taxon' some Eubacteria"

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

output of http://purl.obolibrary.org/obo/RO_0002353

Added

overlaps http://purl.obolibrary.org/obo/RO_0002131

Added

part_of http://purl.obolibrary.org/obo/BFO_0000050

Added

participates in http://purl.obolibrary.org/obo/RO_0000056

Added

preceded_by http://purl.obolibrary.org/obo/BFO_0000062

Added

precedes http://purl.obolibrary.org/obo/BFO_0000063

Added

present in taxon http://purl.obolibrary.org/obo/RO_0002175

Added

  • present in taxon comment "The SPARQL expansion for this relation introduces new named classes into the ontology. For this reason it is likely that the expansion should only be performed during a QC pipeline; the expanded output should usually not be included in a published version of the ontology."

produced_by http://purl.obolibrary.org/obo/RO_0003001

Added

produces http://purl.obolibrary.org/obo/RO_0003000

Added

simultaneous with http://purl.obolibrary.org/obo/RO_0002082

Added

skeleton of http://purl.obolibrary.org/obo/RO_0002576

Added

starts http://purl.obolibrary.org/obo/RO_0002223

Added

starts with http://purl.obolibrary.org/obo/RO_0002224

Added

supplies http://purl.obolibrary.org/obo/RO_0002178

Added

  • supplies editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between an artery and an anatomical structure"

  • supplies IAO_0000119 20064205

surrounded by http://purl.obolibrary.org/obo/RO_0002219

Added

surrounds http://purl.obolibrary.org/obo/RO_0002221

Added

transformation of http://purl.obolibrary.org/obo/RO_0002494

Added

tributary_of http://purl.obolibrary.org/obo/RO_0002376

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Added

Ontology annotations

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

IAO_0000589 http://purl.obolibrary.org/obo/IAO_0000589

Added

RO_0002575 http://purl.obolibrary.org/obo/RO_0002575

Added

adjacent_to http://purl.obolibrary.org/obo/RO_0002220

Added

attached to http://purl.obolibrary.org/obo/RO_0002371

Added

attached to part of http://purl.obolibrary.org/obo/RO_0002177

Added

bounding layer of http://purl.obolibrary.org/obo/RO_0002007

Added

branching_part_of http://purl.obolibrary.org/obo/RO_0002380

Added

capable of part of http://purl.obolibrary.org/obo/RO_0002216

Added

citesAsAuthority http://purl.org/spar/cito/citesAsAuthority

Added

composed primarily of http://purl.obolibrary.org/obo/RO_0002473

Added

confers advantage in http://purl.obolibrary.org/obo/RO_0002322

Added

  • confers advantage in IAO_0000118 "adapted for"

  • confers advantage in IAO_0000117 "Chris Mungall"

  • confers advantage in editor note "An experimental relation currently used to connect a feature possessed by an organism (e.g. anatomical structure, biological process, phenotype or quality) to a habitat or environment in which that feature is well suited, adapted or provides a reproductive advantage for the organism. For example, fins to an aquatic environment. Usually this will mean that the structure is adapted for this environment, but we avoid saying this directly - primitive forms of the structure may not have evolved specifically for that environment (for example, early wings were not necessarily adapted for an aerial environment). Note also that this is a statement about the general class of structures - not every instance of a limb need confer an advantage for a terrestrial environment, e.g. if the limb is vestigial."

  • confers advantage in in_subset ro-eco

connected to http://purl.obolibrary.org/obo/RO_0002170

Added

connects http://purl.obolibrary.org/obo/RO_0002176

Added

contains http://purl.obolibrary.org/obo/RO_0001019

Added

continuous_with http://purl.obolibrary.org/obo/RO_0002150

Added

contributes to morphology of http://purl.obolibrary.org/obo/RO_0002433

Added

developmentally_induced_by http://purl.obolibrary.org/obo/RO_0002256

Added

developmentally_replaces http://purl.obolibrary.org/obo/RO_0002285

Added

develops from part of http://purl.obolibrary.org/obo/RO_0002225

Added

develops in http://purl.obolibrary.org/obo/RO_0002226

Added

directly develops from http://purl.obolibrary.org/obo/RO_0002207

Added

drains http://purl.obolibrary.org/obo/RO_0002179

Added

  • drains editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between a vein and an anatomical structure"

  • drains IAO_0000119 20064205

ends http://purl.obolibrary.org/obo/RO_0002229

Added

ends with http://purl.obolibrary.org/obo/RO_0002230

Added

existence ends during http://purl.obolibrary.org/obo/RO_0002492

Added

existence ends during or before http://purl.obolibrary.org/obo/RO_0002497

Added

existence ends with http://purl.obolibrary.org/obo/RO_0002493

Added

  • existence ends with IAO_0000117 "Chris Mungall"

  • existence ends with comment "The relations here were created based on work originally by Fabian Neuhaus and David Osumi-Sutherland. The work has not yet been vetted and errors in definitions may have occurred during transcription."

existence starts and ends during http://purl.obolibrary.org/obo/RO_0002491

Added

existence starts during http://purl.obolibrary.org/obo/RO_0002488

Added

existence starts during or after http://purl.obolibrary.org/obo/RO_0002496

Added

existence starts with http://purl.obolibrary.org/obo/RO_0002489

Added

has 2D boundary http://purl.obolibrary.org/obo/RO_0002002

Added

has branching part http://purl.obolibrary.org/obo/RO_0002569

Added

has component http://purl.obolibrary.org/obo/RO_0002180

Added

has member http://purl.obolibrary.org/obo/RO_0002351

Added

has muscle antagonist http://purl.obolibrary.org/obo/RO_0002568

Added

has muscle insertion http://purl.obolibrary.org/obo/RO_0002373

Added

has muscle origin http://purl.obolibrary.org/obo/RO_0002372

Added

has skeleton http://purl.obolibrary.org/obo/RO_0002551

Added

has_part http://purl.obolibrary.org/obo/BFO_0000051

Added

immediate transformation of http://purl.obolibrary.org/obo/RO_0002495

Added

immediately preceded by http://purl.obolibrary.org/obo/RO_0002087

Added

in taxon http://purl.obolibrary.org/obo/RO_0002162

Added

innervated_by http://purl.obolibrary.org/obo/RO_0002005

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Added

located in http://purl.obolibrary.org/obo/RO_0001025

Added

location of http://purl.obolibrary.org/obo/RO_0001015

Added

lumen of http://purl.obolibrary.org/obo/RO_0002571

Added

luminal space of http://purl.obolibrary.org/obo/RO_0002572

Added

only in taxon http://purl.obolibrary.org/obo/RO_0002160

Added

'in taxon' some Eukaryota DisjointWith 'in taxon' some Eubacteria"

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

output of http://purl.obolibrary.org/obo/RO_0002353

Added

overlaps http://purl.obolibrary.org/obo/RO_0002131

Added

part_of http://purl.obolibrary.org/obo/BFO_0000050

Added

participates in http://purl.obolibrary.org/obo/RO_0000056

Added

preceded_by http://purl.obolibrary.org/obo/BFO_0000062

Added

precedes http://purl.obolibrary.org/obo/BFO_0000063

Added

present_in_taxon http://purl.obolibrary.org/obo/RO_0002175

Added

  • present_in_taxon comment "The SPARQL expansion for this relation introduces new named classes into the ontology. For this reason it is likely that the expansion should only be performed during a QC pipeline; the expanded output should usually not be included in a published version of the ontology."

produced_by http://purl.obolibrary.org/obo/RO_0003001

Added

produces http://purl.obolibrary.org/obo/RO_0003000

Added

simultaneous with http://purl.obolibrary.org/obo/RO_0002082

Added

skeleton of http://purl.obolibrary.org/obo/RO_0002576

Added

starts http://purl.obolibrary.org/obo/RO_0002223

Added

starts with http://purl.obolibrary.org/obo/RO_0002224

Added

supplies http://purl.obolibrary.org/obo/RO_0002178

Added

  • supplies editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between an artery and an anatomical structure"

  • supplies IAO_0000119 20064205

surrounded by http://purl.obolibrary.org/obo/RO_0002219

Added

surrounds http://purl.obolibrary.org/obo/RO_0002221

Added

transformation of http://purl.obolibrary.org/obo/RO_0002494

Added

tributary_of http://purl.obolibrary.org/obo/RO_0002376

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Added

Ontology annotations

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2022-08-18/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

IAO_0000589 http://purl.obolibrary.org/obo/IAO_0000589

Added

RO_0002575 http://purl.obolibrary.org/obo/RO_0002575

Added

adjacent_to http://purl.obolibrary.org/obo/RO_0002220

Added

attached to part of http://purl.obolibrary.org/obo/RO_0002177

Added

attaches_to http://purl.obolibrary.org/obo/RO_0002371

Added

bounding layer of http://purl.obolibrary.org/obo/RO_0002007

Added

branching_part_of http://purl.obolibrary.org/obo/RO_0002380

Added

capable of part of http://purl.obolibrary.org/obo/RO_0002216

Added

citesAsAuthority http://purl.org/spar/cito/citesAsAuthority

Added

composed primarily of http://purl.obolibrary.org/obo/RO_0002473

Added

confers advantage in http://purl.obolibrary.org/obo/RO_0002322

Added

  • confers advantage in IAO_0000118 "adapted for"

  • confers advantage in IAO_0000117 "Chris Mungall"

  • confers advantage in editor note "An experimental relation currently used to connect a feature possessed by an organism (e.g. anatomical structure, biological process, phenotype or quality) to a habitat or environment in which that feature is well suited, adapted or provides a reproductive advantage for the organism. For example, fins to an aquatic environment. Usually this will mean that the structure is adapted for this environment, but we avoid saying this directly - primitive forms of the structure may not have evolved specifically for that environment (for example, early wings were not necessarily adapted for an aerial environment). Note also that this is a statement about the general class of structures - not every instance of a limb need confer an advantage for a terrestrial environment, e.g. if the limb is vestigial."

  • confers advantage in in_subset ro-eco

connected to http://purl.obolibrary.org/obo/RO_0002170

Added

connects http://purl.obolibrary.org/obo/RO_0002176

Added

contains http://purl.obolibrary.org/obo/RO_0001019

Added

continuous_with http://purl.obolibrary.org/obo/RO_0002150

Added

contributes to morphology of http://purl.obolibrary.org/obo/RO_0002433

Added

developmentally replaces http://purl.obolibrary.org/obo/RO_0002285

Added

developmentally_induced_by http://purl.obolibrary.org/obo/RO_0002256

Added

develops from part of http://purl.obolibrary.org/obo/RO_0002225

Added

develops in http://purl.obolibrary.org/obo/RO_0002226

Added

directly develops from http://purl.obolibrary.org/obo/RO_0002207

Added

drains http://purl.obolibrary.org/obo/RO_0002179

Added

  • drains editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between a vein and an anatomical structure"

  • drains IAO_0000119 20064205

ends http://purl.obolibrary.org/obo/RO_0002229

Added

ends with http://purl.obolibrary.org/obo/RO_0002230

Added

existence ends during http://purl.obolibrary.org/obo/RO_0002492

Added

existence ends during or before http://purl.obolibrary.org/obo/RO_0002497

Added

existence ends with http://purl.obolibrary.org/obo/RO_0002493

Added

  • existence ends with IAO_0000117 "Chris Mungall"

  • existence ends with comment "The relations here were created based on work originally by Fabian Neuhaus and David Osumi-Sutherland. The work has not yet been vetted and errors in definitions may have occurred during transcription."

existence starts and ends during http://purl.obolibrary.org/obo/RO_0002491

Added

existence starts during http://purl.obolibrary.org/obo/RO_0002488

Added

existence starts during or after http://purl.obolibrary.org/obo/RO_0002496

Added

existence starts with http://purl.obolibrary.org/obo/RO_0002489

Added

has 2D boundary http://purl.obolibrary.org/obo/RO_0002002

Added

has branching part http://purl.obolibrary.org/obo/RO_0002569

Added

has component http://purl.obolibrary.org/obo/RO_0002180

Added

has member http://purl.obolibrary.org/obo/RO_0002351

Added

has muscle antagonist http://purl.obolibrary.org/obo/RO_0002568

Added

has muscle insertion http://purl.obolibrary.org/obo/RO_0002373

Added

has muscle origin http://purl.obolibrary.org/obo/RO_0002372

Added

has skeleton http://purl.obolibrary.org/obo/RO_0002551

Added

has_part http://purl.obolibrary.org/obo/BFO_0000051

Added

immediate transformation of http://purl.obolibrary.org/obo/RO_0002495

Added

immediately preceded by http://purl.obolibrary.org/obo/RO_0002087

Added

in taxon http://purl.obolibrary.org/obo/RO_0002162

Added

innervated_by http://purl.obolibrary.org/obo/RO_0002005

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Added

located in http://purl.obolibrary.org/obo/RO_0001025

Added

location of http://purl.obolibrary.org/obo/RO_0001015

Added

lumen of http://purl.obolibrary.org/obo/RO_0002571

Added

luminal space of http://purl.obolibrary.org/obo/RO_0002572

Added

only in taxon http://purl.obolibrary.org/obo/RO_0002160

Added

'in taxon' some Eukaryota DisjointWith 'in taxon' some Eubacteria"

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

output of http://purl.obolibrary.org/obo/RO_0002353

Added

overlaps http://purl.obolibrary.org/obo/RO_0002131

Added

part_of http://purl.obolibrary.org/obo/BFO_0000050

Added

participates in http://purl.obolibrary.org/obo/RO_0000056

Added

preceded_by http://purl.obolibrary.org/obo/BFO_0000062

Added

precedes http://purl.obolibrary.org/obo/BFO_0000063

Added

present_in_taxon http://purl.obolibrary.org/obo/RO_0002175

Added

  • present_in_taxon comment "The SPARQL expansion for this relation introduces new named classes into the ontology. For this reason it is likely that the expansion should only be performed during a QC pipeline; the expanded output should usually not be included in a published version of the ontology."

produced_by http://purl.obolibrary.org/obo/RO_0003001

Added

produces http://purl.obolibrary.org/obo/RO_0003000

Added

simultaneous with http://purl.obolibrary.org/obo/RO_0002082

Added

skeleton of http://purl.obolibrary.org/obo/RO_0002576

Added

starts http://purl.obolibrary.org/obo/RO_0002223

Added

starts with http://purl.obolibrary.org/obo/RO_0002224

Added

supplies http://purl.obolibrary.org/obo/RO_0002178

Added

  • supplies editor note "Individual ontologies should provide their own constraints on this abstract relation. For example, in the realm of anatomy this should hold between an artery and an anatomical structure"

  • supplies IAO_0000119 20064205

surrounded by http://purl.obolibrary.org/obo/RO_0002219

Added

surrounds http://purl.obolibrary.org/obo/RO_0002221

Added

transformation of http://purl.obolibrary.org/obo/RO_0002494

Added

tributary_of http://purl.obolibrary.org/obo/RO_0002376

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

otic ganglion http://purl.obolibrary.org/obo/UBERON_0003963

Removed

Added

@shawntanzk
Copy link
Collaborator Author

also why is the robot diff actions going crazy >.< lol

@shawntanzk
Copy link
Collaborator Author

Currently trying to build uberon fails at

make[1]: *** [uberon.Makefile:652: reports/taxon-constraint-check.txt] Error 1
make[1]: Leaving directory '/work/src/ontology'
make: *** [uberon.Makefile:1306: uberon] Error 2

Looking into taxon-constraint-check.txt.tmp

UNSAT: EV:0100358 EV:0100358
UNSAT: HBA:9371 HBA:9371
UNSAT: FMA:312393 FMA:312393
UNSAT: EMAPA:16914 EMAPA:16914
UNSAT: MA:0000054 MA:0000054
UNSAT: EMAPA:16917 EMAPA:16917
NUMBER_OF_UNSATISFIABLE_CLASSES: 6

On investigation, all these dbxref have 2 terms that are mapped to them, which I'm guessing isn't allowed if we are making equiv classes out of them?

@shawntanzk
Copy link
Collaborator Author

closing for #2624

@shawntanzk shawntanzk closed this Aug 19, 2022
@shawntanzk shawntanzk deleted the 2022-08-16_release branch August 19, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants