-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022-08-16 release #2615
2022-08-16 release #2615
Conversation
I checked that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive release:
- remove renal-minimal files from version control with git rm. Make sure they are in .gitignore.
- Check uberon.owl for dangling classes, there seem to be hundreds of removed terms in our imports
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002405"/> | ||
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002416"/> | ||
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0002423"/> | ||
<owl:disjointWith rdf:resource="http://purl.obolibrary.org/obo/UBERON_0004456"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of disjointnesses remove, intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvarner-ebi & @nicolevasilevsky - I assume this is the work you guys did with the renal system stuff? could you check this please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawntanzk, sorry, these do not look familiar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry @balhoff - ignore that, was looking at the wrong thing >.<
strange that the renal-minimal files got through, there is already this in .gitignore:
|
I saw in |
Anita my guess is: never in taxon are somehow not read by seed extraction process. Don't know why it ever worked.. |
But all classes in the image are used with |
Can someone verify that http://purl.obolibrary.org/obo/ncbitaxon/subsets/taxslim.owl contains all of these IDs now dangling? |
It doesn't contain any of these terms. |
Can you make a PR here: https://github.com/obophenotype/ncbitaxon/blob/master/subsets/taxon-subset-ids.txt to get them in and assign me? We will drive fast to get this resolved |
While we are working on this - are all the other dangling classes expected? |
1 GO term (http://purl.obolibrary.org/obo/GO_0097254) that should not be dangling http://purl.obolibrary.org/obo/RnorDv_0000010 -> not sure what this is |
Caro seems to be a proper import of uberon, but not included in the edit file. @shawntanzk can you try to add the caro import to the edit file and see if this breaks the uberon release? |
Whats the usage of teh GO dangler? |
on edit file seems to work fine - have not built the release file - happy to fix the danglers and make uberon if you arent already doing it? |
No I am not working on it |
Ok try refrshig imports https://github.com/obophenotype/ncbitaxon/releases/tag/v2022-08-17 |
on it |
Tried refreshing all imports, no change |
Just saw the NCBITaxon tagged as pre-release instead of latest - could this be the problem? |
Looks like the issue was brought in with the reinstatement of CARO as an import - maybe why it was removed before? |
Excellent this exact query should be a GitHub action, which if it fails, posts the unsat as a comment to the PR. Wouldnt this be awesome? And lucking at this query, while being tired and annoyed, can't help you feel amazed by the awesomeness of the tech for this particular use case. No other stack can do that. Finding an inconsistency like that. |
Not sure man this unsat looks pretty legit to me. Removing caro would just hide an inconsistency! |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000589
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsAddedOntology annotations |
Unsat related to #2589 |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000589
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsAddedOntology annotationsotic ganglion
|
seems like it all leads back to multi-cell-part structure DisjointWith multicellular anatomical structure again |
Can you remove the disjointness axiom and see if that gets the release to run through? |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000589
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsAddedOntology annotationsotic ganglion
|
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000589
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsAddedOntology annotationsotic ganglion
|
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsIAO_0000589
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsotic ganglion
|
also why is the robot diff actions going crazy >.< lol |
Currently trying to build uberon fails at
Looking into taxon-constraint-check.txt.tmp
On investigation, all these dbxref have 2 terms that are mapped to them, which I'm guessing isn't allowed if we are making equiv classes out of them? |
closing for #2624 |
No description provided.