Replace all uses of DCE with DC and add violation check #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmungall
approved these changes
Mar 1, 2023
matentzn
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
We are now getting to see how useful qc profile centralisation would be. @StroemPhi
|
Ready to merge after conflict resolution |
|
@matentzn merge/conflict resolution is done. Next steps:
|
PR here: https://github.com/INCATools/ontology-development-kit/tree/master/template/src/sparql
It always is: https://github.com/oborel/obo-relations/pull/692/checks#step:4:26 |
cthoyt
added a commit
to cthoyt/ontology-development-kit
that referenced
this pull request
Mar 1, 2023
This is a follow-up to oborel/obo-relations#692
anitacaron
added a commit
to INCATools/ontology-development-kit
that referenced
this pull request
Oct 4, 2023
* Add SPARQL to find uses of deprecated DC This is a follow-up to oborel/obo-relations#692 * remove misplaced sparql query * add `dc-properties` custom sparql check * update file name * filter on terms using ontology namespaces --------- Co-authored-by: Anita Caron <anitacaron@users.noreply.github.com> Co-authored-by: Anita Caron <anitac@ebi.ac.uk> Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691
This PR does the following:
DCEwithDCDCEprefix from the definitions and clean up corresponding declarationsDCEWhen you run
sh run.sh make sparql_test, there should be no errors.