Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARO to Uberon term replacement for #695 #722

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

ddooley
Copy link
Contributor

@ddooley ddooley commented May 27, 2023

For #695. Required importing OBI:0100026 organism in new obi_terms.txt module. This will get switched to COB when COB gets OBI:organism
Makes use of new uberon_terms.txt module.
Removes caro_terms.txt module

ddooley added 3 commits May 27, 2023 13:43
Will switch to COB once it has OBI:0100026
Note a number of object property domain and range get switched.
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller issues with the way the imports are referred to

src/ontology/catalog-v001.xml Outdated Show resolved Hide resolved
src/ontology/catalog-v001.xml Outdated Show resolved Hide resolved
src/ontology/catalog-v001.xml Show resolved Hide resolved
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
src/ontology/ro-edit.owl Outdated Show resolved Hide resolved
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller issues with the way the imports are referred to

ddooley and others added 5 commits May 28, 2023 17:21
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
Co-authored-by: Nico Matentzoglu <nicolas.matentzoglu@gmail.com>
@anitacaron anitacaron requested a review from matentzn June 12, 2023 10:07
@anitacaron anitacaron self-requested a review June 12, 2023 10:21
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants