Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up files #725

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Clean up files #725

merged 3 commits into from
Jun 26, 2023

Conversation

@anitacaron anitacaron self-assigned this Jun 12, 2023
@anitacaron anitacaron requested a review from matentzn June 12, 2023 11:29
@wdduncan
Copy link
Collaborator

The BFO classes no longer have labels. E.g.:

image

Are you moving the BFO classes to another import? They should not be deleted if they are being used.

@anitacaron
Copy link
Collaborator Author

The files I removed are at the root level. The same files are in the src/ontology/components.

It's not showing the labels because it's missing the declaration of these files in the catalog. Damien has fixed that in this commit.

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep bfo-axioms and bfo-classes-minimal as they are, the rest is fine!

@anitacaron anitacaron requested a review from matentzn June 23, 2023 16:16
@wdduncan wdduncan merged commit 5b733cd into master Jun 26, 2023
@cthoyt
Copy link
Collaborator

cthoyt commented Jun 26, 2023

this is really really bad, look at the commit history

Screenshot 2023-06-26 at 23 04 38

we have a commit to the main branch that breaks it. then this one on top of it, adding to the issues. I think we need to hard reset to 2 commits on master ago to the last non-broken commit and immediately enforce protection on main branch
that CI has to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post ODK Migration Clean up
4 participants