-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: optimistic search page loading and improved content refinement #415
Merged
njhale
merged 1 commit into
obot-platform:main
from
njhale:fix/google-search-load-timeouts
Feb 7, 2025
Merged
enhance: optimistic search page loading and improved content refinement #415
njhale
merged 1 commit into
obot-platform:main
from
njhale:fix/google-search-load-timeouts
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c47592
to
4fb8ab2
Compare
4fb8ab2
to
c58e7e3
Compare
g-linville
approved these changes
Feb 7, 2025
google/search/src/refine.ts
Outdated
- boilerplate and unintelligable text | ||
- unrelated advertisements, links, and web page structure | ||
2. Select excerpts from the refined content that you think would make good notes for conducting detailed research about the topic | ||
3. Compose a concise markdown document containing the excerpts organized in decending order of importance to understanding the topic. Do not paraphrase, summarize, or reword the excerpts. The goal is to preserve as much of the original content as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
3. Compose a concise markdown document containing the excerpts organized in decending order of importance to understanding the topic. Do not paraphrase, summarize, or reword the excerpts. The goal is to preserve as much of the original content as possible. | |
3. Compose a concise markdown document containing the excerpts organized in descending order of importance to understanding the topic. Do not paraphrase, summarize, or reword the excerpts. The goal is to preserve as much of the original content as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! Pushed.
Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
c58e7e3
to
f1903b1
Compare
thedadams
approved these changes
Feb 7, 2025
njhale
added a commit
to njhale/tools
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
Google Search
page loading, scraping, and LLM-based content refinement.This PR includes the following enhancements:
Google Search
tool output token budget across results based on their size and the quality of their content when truncating refined search result content (the goal is to keep shorter, higher quality, content as intact as possible)Requires the
gptscript
module in Obot to be bumped to a version that includes: #415 (see obot-platform/obot#1680 for bump PR)Also addresses: obot-platform/obot#1671 and obot-platform/obot#1423