feat: custom message based throughput measurements #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
feat/custom-message-based-measurements
branch
from
ae87af7
to
332bd5a
Compare
BinaryFissionGames
changed the base branch from
release/v1.54.0
to
release/v1.55.0
dpaasman00
approved these changes
Jul 3, 2024
BinaryFissionGames
force-pushed
the
feat/custom-message-based-measurements
branch
from
578e3ec
to
9e33cc1
Compare
|
|
BinaryFissionGames
changed the base branch from
release/v1.55.0
to
release/v1.58.0
BinaryFissionGames
force-pushed
the
feat/custom-message-based-measurements
branch
from
bb92ae9
to
3b91ec0
Compare
BinaryFissionGames
changed the base branch from
release/v1.58.0
to
release/v1.59.0
BinaryFissionGames
added a commit
that referenced
this pull request
Sep 3, 2024
* start on second processor * start on handler stuff * work on interface for metrics * add shared throughput measurement struct * implement bindplane extension getting metrics * hook up bindplane extension to throughput measurements * add start func to throughput measurement * tweak some extension logic * add timestamp to measurements * skip 0 value metrics * working towards bindplane-agent using custom message throughput * add tags to build * update opamp to v0.14.0 * Hook up measurements to agent * set capabilities * add gitignore for config.yaml and storage dir * remove extraneous resetting of registry * delete unused file * bring modules up to date * add license * lint * fix compile error * handle error from SetCustomCapabilities * fix manager reload test * fix test * remove random jitter * make tidy, bump modules * test measurements package * remove todo * test measurements sender * add license * remove unused config field * non-blocking send * fix throughput tests * Allow configuring addtional fixed attributes for all throughput measurment processors * limit retries for sending measurements * Make measurements interval non-pointer * fix yaml tag instead of mapstructure * fix measurements reload to actually update interval/attrs * Reconfigure extra attributes when sent * remove ldflags from make test * bring internal module versions up to date * make sure otel up-to-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
These measurements are emitted over an OpAMP connection.
In bindplane-agent, throughput measurements are associated with a static registry, which holds all the throughput measurements. The measurements in this repository is reported to BindPlane over custom messages if the BindPlane server supports the capability.
In an OCB build of the collector, an optional bindplane extension may be specified to use as a registry for throughput metrics. In this case, the bindplane extension will use an opamp extension to report throughput metrics to the BindPlane server.
Regardless of either of these, the throughputmeasurements processor still registers metrics with the collector's self-metrics, so the metrics remain available over prometheus, which makes this change backwards compatible.
Checklist