deps: Use internal/tools for tools rather than install from Makefile
#1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonblock
requested changes
Jun 25, 2024
dpaasman00
force-pushed
the
chore/tools-folder
branch
from
2cd43b2
to
67b65e1
Compare
jsirianni
requested changes
Jun 25, 2024
Yea, not entirely sure what the issue is with it either. BPOP has the same issue/error and we resolve it by adding it to an ignore list for gosec, so I did that here and it should be passing now. |
|
I think the |
antonblock
reviewed
Jun 25, 2024
antonblock
approved these changes
Jun 25, 2024
antonblock
force-pushed
the
chore/tools-folder
branch
from
cfd01d5
to
c88073a
Compare
dpaasman00
force-pushed
the
chore/tools-folder
branch
from
c88073a
to
12e1999
Compare
jsirianni
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Updating OTel to v0.103.0 introduces a breaking change in code that mdatagen generates. We've put off updating mdatagen for a while now because doing so caused issues but now we are forced to update it to pull in the new OTel update. In order to update mdatagen (will be done in PR after this one) we need to change how we handle tools.
Checklist