chore: Test caching to speed up test action #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
chore/ci-test-cache
branch
from
8321a13
to
48ec43d
Compare
dpaasman00
requested review from
andykellr,
antonblock and
jsirianni
and removed request for
andykellr
BinaryFissionGames
approved these changes
Aug 28, 2024
antonblock
approved these changes
Aug 28, 2024
dpaasman00
force-pushed
the
chore/ci-test-cache
branch
from
dc34e2e
to
63fc318
Compare
BinaryFissionGames
pushed a commit
that referenced
this pull request
Sep 3, 2024
* test caching to speed up test action * test removing cache * add cache dependency path for all go.sum * test w/o recursive go.sum match * Revert "test w/o recursive go.sum match" This reverts commit b2bf7a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Trying to speed up CI after running into issues with the release and needing to wait on CI. Unfortunately the only real bottle neck is downloading dependencies, so for a single CI run there's not much that can be done. By default, the setup-go action will cache the root go.sum but with this change we're going to also cache nested go.sum files. With some rough testing I found this does speed up CI.
These are the results of some rough testing. In general I think caching the nested go.sum files does improve CI speed but it can definitely vary and this probably isn't definitive (such as windows tests taking longer with nested caching vs just the root).
Checklist