Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline expressions following literal backticks are not parsed correctly #1433

Closed
mbostock opened this issue Jun 6, 2024 · 1 comment
Closed

Inline expressions following literal backticks are not parsed correctly #1433

mbostock opened this issue Jun 6, 2024 · 1 comment
Assignees
@mbostock
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

mbostock commented Jun 6, 2024

Minimal reproduction:

<code>```</code>

<pre>${`1`}</pre>

The ${`1`} should be interpreted as an inline expression, but it’s not. Probably a bug in how code spans are parsed.
@mbostock mbostock added the bug Something isn’t working label Jun 6, 2024
@mbostock mbostock self-assigned this Jun 6, 2024
@mbostock
Copy link
Member Author

mbostock commented Jun 6, 2024

Fixed in #1438.

@mbostock mbostock closed this as completed Jun 6, 2024
Fil added a commit that referenced this issue Jun 7, 2024
@Fil
test inline expressions following literal backticks #1433
629dc98
@Fil Fil mentioned this issue Jun 7, 2024
Merged
mbostock added a commit that referenced this issue Jun 7, 2024
@Fil @mbostock
a few parsing tests (#1442)
ccc3a31 
* test setext #1436.

* test inline expression within triple backtick within HTML #1435.

* test inline expressions within indented lines #1434

* test inline expressions following literal backticks #1433

* test inline expressions within lists with backticks #1437

* test SVG placeholder #1415

* only <observablehq-loading> in HTML

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock