clear old content on undefine #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Jun 6, 2024
| @@ -119,7 +118,8 @@ function displayBlock(root, value) { | |||
| } | |||
|
|
|||
| export function undefine(id) { | |||
| cellsById.get(id)?.variables.forEach((v) => v.delete()); | |||
| clear(rootsById.get(id)); | |||
| cellsById.get(id).variables.forEach((v) => v.delete()); | |||
There was a problem hiding this comment.
I removed the optional chaining here because we should only be undefining cells that were defined (and we want to notice if our logic is broken).
Fil
approved these changes
Jun 6, 2024
Merged
mbostock
added a commit
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1430. We were forgetting to clear old content when a cell is undefined during preview.