file.size #1608
Merged
file.size #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might enable some smarter heuristics for DuckDBClient, such as using |
mbostock
commented
Aug 27, 2024
Comment on lines
+4
to
+34
| export { | ||
| button, | ||
| checkbox, | ||
| radio, | ||
| toggle, | ||
| color, | ||
| date, | ||
| datetime, | ||
| form, | ||
| range, | ||
| number, | ||
| search, | ||
| searchFilter, | ||
| select, | ||
| table, | ||
| text, | ||
| email, | ||
| tel, | ||
| url, | ||
| password, | ||
| textarea, | ||
| input, | ||
| bind, | ||
| disposal, | ||
| formatDate, | ||
| formatLocaleAuto, | ||
| formatLocaleNumber, | ||
| formatTrim, | ||
| formatAuto, | ||
| formatNumber | ||
| } from "@observablehq/inputs"; |
There was a problem hiding this comment.
Repeating this is unfortunate but ESLint doesn’t like us exporting file twice. 😞
Fil
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as draft until observablehq/inputs#266 is merged and Inputs 0.12.0 is released.Done.Also, I think I can clean up the implementation slightly (like maybe consolidatingDone. Also fixes an unfiled bug wheregetSourceLastModifiedandgetSourceSizeintogetSourceInfo).file.hrefdidn’t work forInputs.file.