fix hashes for modules importing builtins #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
Sep 26, 2024
| export function resolveBuiltin(specifier: string): string { | ||
| if (builtins.has(specifier)) return builtins.get(specifier)!; | ||
| if (!specifier.startsWith("observablehq:")) throw new Error(`not built-in: ${specifier}`); | ||
| return `/_observablehq/${specifier.slice("observablehq:".length)}${extname(specifier) ? "" : ".js"}`; |
There was a problem hiding this comment.
took me a moment to figure out what case that was!
one example: import {mutable} from "observablehq:stdlib/mutable.js";
There was a problem hiding this comment.
Yep! The primary one is observablehq:stdlib/inputs.css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLocalModuleHashwas computing the wrong result for modules that import built-ins such asobservablehq:stdlibandnpm:@observablehq/inputs; it needs to incorporate the Framework version number so that when a new version of Framework is released and the built-in modules may have changed, the hash of the importing local module also changes. (We already do something similar fornpm:imports.)We were also forgetting to handle
jsr:imports here.Related #1555 #1557.