hide and disable the table selection inputs #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Apr 29, 2022
mbostock
reviewed
Apr 29, 2022
CobusT
reviewed
Apr 30, 2022
| @@ -54,6 +54,7 @@ function initialize( | |||
| rows = 11.5, // maximum number of rows to show | |||
| width = {}, // object of column name to width, or overall table width | |||
| multiple = true, | |||
| select: selectable = true, // is the table selectable? | |||
There was a problem hiding this comment.
I find selectable a bit more descriptive than select as an option. Thoughts?
There was a problem hiding this comment.
I have no preference; in the code I've been using selectable because the name is already used by the select function.
|
Do we normally include the changes to the documentation (README) to these PRs or are those done separately? |
mbostock
changed the title
|
Merged into #262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #136