Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tip & faceting #1778

Closed
yurivish opened this issue Aug 2, 2023 · 2 comments · Fixed by #1779
Closed

Tip & faceting #1778

yurivish opened this issue Aug 2, 2023 · 2 comments · Fixed by #1779
Assignees
@Fil
Labels
bug Something isn’t working

Comments

@yurivish
Copy link
Contributor

yurivish commented Aug 2, 2023

I happened to notice an oddity with selections and faceting: https://observablehq.com/d/a03f70ae5c5962c4

It might be related to #1776 but I can still reproduce the behavior I'm seeing with PlotF from the notebook linked in #1777 so it does not look like the fix for that one also fixes this one.

image

In this plot, the selection can sometimes be null even though the user is hovering over an item. Giving the plot a wide width fixes it, so it might have to do with the transition between facets and the sequencing of the events that triggers. Interestingly, moving from left to right seems to work, but not right to left.
@Fil
Copy link
Contributor

Fil commented Aug 2, 2023 •
edited
Loading

Thanks for the report! It's a different bug, which happens when two facets change their value at the same time: they both dispatch an event, and the last one wins; the bug happens when the last one is the exiting facet.

@Fil Fil self-assigned this Aug 2, 2023
Fil added a commit that referenced this issue Aug 2, 2023
@Fil
When simultaneously exiting a facet and entering a new one, prioritiz…
9a3dc5f 
…e dispatching the value from the entering facet.

Fixes #1778
@Fil Fil mentioned this issue Aug 2, 2023
Merged
@Fil Fil added the bug Something isn’t working label Aug 2, 2023
@yurivish
Copy link
Contributor Author

yurivish commented Aug 2, 2023

🎉 Thanks for the fix!

@Fil Fil closed this as completed in #1779 Aug 3, 2023
Fil added a commit that referenced this issue Aug 3, 2023
@Fil @mbostock
fix: pointer interaction was not always dispatching the new value (#1779
1d4e82c 
)

* When simultaneously exiting a facet and entering a new one, prioritize dispatching the value from the entering facet.

Fixes #1778

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Fil added a commit that referenced this issue Aug 21, 2023
@Fil @mbostock
fix: pointer interaction was not always dispatching the new value (#1779
d69960f 
)

* When simultaneously exiting a facet and entering a new one, prioritize dispatching the value from the entering facet.

Fixes #1778

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
chaichontat pushed a commit to chaichontat/plot that referenced this issue Jan 14, 2024
@Fil @mbostock @chaichontat
fix: pointer interaction was not always dispatching the new value (ob…
dd415a4 
…servablehq#1779)

* When simultaneously exiting a facet and entering a new one, prioritize dispatching the value from the entering facet.

Fixes observablehq#1778

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pointer interaction was not always dispatching the new value observablehq/plot
2 participants
@Fil @yurivish