Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named time intervals #1205

Merged
merged 6 commits into from
Jan 17, 2023
Merged

named time intervals #1205

merged 6 commits into from
Jan 17, 2023

Conversation

mbostock
Copy link
Member

Fixes #307. This is going to conflict with #1197, so I could merge the two if desired.

@mbostock mbostock requested a review from Fil December 30, 2022 23:03
@mbostock mbostock added the enhancement New feature or request label Dec 30, 2022
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have extended this a little, as time intervals can be used as thresholds for the bin transform.

@mbostock mbostock force-pushed the mbostock/interval-names branch from 84bd7ab to ada81a0 Compare January 17, 2023 22:45
@mbostock mbostock merged commit c9c2812 into main Jan 17, 2023
@mbostock mbostock deleted the mbostock/interval-names branch January 17, 2023 22:50
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* named time intervals

* named time ticks

* document

* accept named intervals for the thresholds option

* appropriate TODO comment

* minimize diff

Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named time ticks.
2 participants