fix bars with maybe-ordinal reducers #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Feb 15, 2023
Comment on lines
+103
to
+105
| ? isOrdinal(x) || isOrdinal(y) || (xReduce == null && yReduce == null && !isMonotonic(x) && !isMonotonic(y)) | ||
| ? "dot" | ||
| : "line" |
There was a problem hiding this comment.
(This is an unrelated change where I just wanted to get rid of isContinuous by replacing it with !isOrdinal. Sorry for the churn but hopefully it’s clear that this is not changing behavior!)
tophtucker
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another bug where we assumed that reducers produce quantitative values. In some cases, e.g. with the mode reducer, reducing preserves the input value type. For example:
Before, barY is wrongly chosen, resulting in a degenerate plot:
After, cell is correctly chosen, since both x and y are ordinal: