Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no implicit title on derived tip #1658

Merged
merged 1 commit into from
May 30, 2023
Merged

no implicit title on derived tip #1658

merged 1 commit into from
May 30, 2023

Conversation

mbostock
Copy link
Member

Fixes #1657.

@mbostock mbostock requested a review from Fil May 30, 2023 19:18
@Fil Fil mentioned this pull request May 30, 2023
Open
Fil
Fil approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick bug fix. I'd like to explore an alternative (described in #1659), but that might be for later, though.

@mbostock mbostock merged commit 5744399 into main May 30, 2023
@mbostock mbostock deleted the mbostock/no-derived-identity-title branch May 30, 2023 21:24
Fil pushed a commit that referenced this pull request Aug 21, 2023
@mbostock @Fil
no implicit title on derived tip (#1658)
31f7ac5
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
@mbostock @chaichontat
no implicit title on derived tip (observablehq#1658)
c443715
@x-way x-way mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derived tip when grouping primitive values shows the wrong value
2 participants
@mbostock @Fil