fix(forwarder): add parameter validation for source bucket names (#300)

observeinc · Jun 7, 2024 · b3c7acf · b3c7acf
1 parent b07d7a4
commit b3c7acf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/apps/forwarder/template.yaml b/apps/forwarder/template.yaml
@@ -68,6 +68,7 @@ Parameters:
       files copied to Filedrop, you must also subscribe S3 Bucket Notifications
       to the forwarder.
     Default: ''
+    AllowedPattern: "^[a-z0-9-.]*(\\*)?$"
   SourceTopicArns:
     Type: CommaDelimitedList
     Description: >-

diff --git a/apps/stack/template.yaml b/apps/stack/template.yaml
@@ -113,6 +113,7 @@ Parameters:
     Description: >-
       A list of bucket names which the forwarder is allowed to read from.
     Default: ""
+    AllowedPattern: "^[a-z0-9-.]*(\\*)?$"
   ContentTypeOverrides:
     Type: CommaDelimitedList
     Description: >-

diff --git a/integration/tests/stack.tftest.hcl b/integration/tests/stack.tftest.hcl
@@ -158,6 +158,7 @@ run "install" {
       DataAccessPointArn       = run.create_bucket.access_point.arn
       DestinationUri           = "s3://${run.create_bucket.access_point.alias}/"
       ConfigDeliveryBucketName = "example-bucket"
+      SourceBucketNames        = "*"
       LogGroupNamePatterns     = "*"
       NameOverride             = run.setup.id
     }