-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add observe agent helm charts #151
Conversation
|
||
command: | ||
name: "observe-agent" | ||
extraArgs: ["start", "--config=/conf/observe-agent.yaml"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned about the idea of never being able to see the config file that is actually in use. Is it possible to use the code (or some vanilla Go) that assembles the config today to write out a chart to a configmap so it can be used to troubleshoot. I love generating the config off of the higher level abstraction but I worry a lot about a black box config file. Why not write something out instead of assembling in memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to resolve this right now but I think we need to have a conversation about how information will be exposed. The underlying otel collector chart takes config as an argument and produces a config map. Perhaps we could consider a different approach then the host solution takes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, this is a feature request that's come up a good amount. there are proposals and onging work to add it as an extension to zpages and expose an endpoint that returns it but there's no built in support in otel collector today.
@@ -0,0 +1,5 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we will have several more revisions of this chart - I think roles will need some switches base on other configurations if we are taking a least privilege approach.
|
||
command: | ||
name: "observe-agent" | ||
extraArgs: ["start", "--config=/conf/observe-agent.yaml"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--otel_config=/path/to/configmap
No description provided.