feat: add cluster events deployment to agent stack #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-alexlew
force-pushed
the
alew/add-events-configs
branch
from
ca6a820
to
e53bf06
Compare
|
The following chart updates are necessary: |
obs-gh-alexlew
force-pushed
the
alew/add-events-configs
branch
from
5f82ce6
to
b015972
Compare
| fullnameOverride: "observe" | ||
| namespaceOverride: "observe" | ||
| nameOverride: "daemonset" | ||
| namespaceOverride: "k8sexplorer" |
There was a problem hiding this comment.
Why are we switching namespaceOverride?
obs-gh-alexlew
commented
Jul 29, 2024
| path: "observe-agent.yaml" | ||
| defaultMode: 420 | ||
|
|
||
| extraVolumeMounts: |
There was a problem hiding this comment.
Injecting our otel collector config as volume
obs-gh-alexlew
commented
Jul 29, 2024
| key: id | ||
| extraEnvsFrom: [] | ||
| extraVolumes: | ||
| - name: "observe-agent-deployment-config" |
There was a problem hiding this comment.
injecting the observe-agent.yaml as volume
obs-gh-abhishekrao
approved these changes
Jul 30, 2024
xueweiz
approved these changes
Jul 31, 2024
| requests: | ||
| cpu: 250m | ||
| memory: 256Mi | ||
| daemonset: | ||
| daemonset: | ||
| # Resource settings | ||
| resources: | ||
| limits: |
There was a problem hiding this comment.
Thanks for removing these! It will likely reduce some pain for now. Eventually we can provide a config, but that's for later.
| - {name: serviceaccounts, mode: watch} | ||
| processors: | ||
| # needs to come after transform/watch_objects in pipelines | ||
| observek8sattributes: |
There was a problem hiding this comment.
I assume this is the new custom processor.
But yeah the current config.tpl format LGTM. Once we start iterating on it we can have more feedbacks
| | deployment-cluster-events.clusterRole.clusterRoleBinding.name | string | `""` | | | ||
| | deployment-cluster-events.clusterRole.create | bool | `true` | | | ||
| | deployment-cluster-events.clusterRole.name | string | `""` | | | ||
| | deployment-cluster-events.clusterRole.rules[0].apiGroups[0] | string | `""` | | |
There was a problem hiding this comment.
This seems a little painful...
I guess it's so that we allow customer to restrict the access for this agent easier?
(Either way this comment doesn't block this PR
There was a problem hiding this comment.
this is just the schema for the otel-collector open source chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.