Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updatecli configs for agent stack #193

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

obs-gh-alexlew
Copy link
Contributor

No description provided.

@obs-gh-alexlew
Copy link
Contributor Author

seems like test-charts is just broken? specifically the helm/chart-testing-action

helm/chart-testing-action#156 might fix?

@obs-gh-alexlew obs-gh-alexlew force-pushed the alew/ob-35960 branch 2 times, most recently from 9be27b9 to 4918307 Compare August 28, 2024 16:42
@obs-gh-abhishekrao
Copy link
Contributor

Do we also need updatecli/external rules for when the agent has a new image or something similar? Currently it seems we refer to the opentelemetry-collector charts so that's another angle to look at as well.

@obs-gh-alexlew
Copy link
Contributor Author

to me it seems like bumping otel-collector-chart/agent versions should be a manual action and not something automated by updatecli. We don't always want to be on latest. It is useful to open a PR for us with updates but until the integration testing is ready, I think it's better to leave bumps + testing as a manual action.

@obs-gh-alexlew obs-gh-alexlew merged commit 0222702 into main Aug 29, 2024
7 checks passed
@obs-gh-alexlew obs-gh-alexlew deleted the alew/ob-35960 branch August 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants