fix: OB-35984-add-namespace-name-to-cluster-role #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur-observe
force-pushed
the
arthur/OB-35984-cluster-role-name-fix
branch
from
3add460
to
bab290e
Compare
xueweiz
approved these changes
Aug 30, 2024
arthur-observe
force-pushed
the
arthur/OB-35984-cluster-role-name-fix
branch
4 times, most recently
from
1e5dfc6
to
7cda13d
Compare
- Add the namespace name to cluster role and cluster role binding - Make configmap creation conditional based on enabled flag for deployment/daemonset - Make entity token use value drive exporter creation
arthur-observe
force-pushed
the
arthur/OB-35984-cluster-role-name-fix
branch
from
7cda13d
to
0e4e479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a use field to entity token because we have to separate the creation of the secret from the usage because we deploy secrets is a separate workflow on our clusters. Should all be temporary.
@xueweiz and I validated that this branch auto generates yaml that deploys on eng using kustomize.
Related pr - https://gerrit.observeinc.com/c/observe/+/55077