fix: OB-37389 Obfuscate secrets inside Secret previous configuration #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/obfuscateSecrets
branch
2 times, most recently
from
d442766
to
68d0f04
Compare
xueweiz
approved these changes
Oct 5, 2024
| @@ -8,6 +8,16 @@ const ( | |||
| RedactedSecretValue = "REDACTED" | |||
| ) | |||
|
|
|||
| var keysMightContainSecret map[string]struct{} | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
I think you don't need these anymore?
There was a problem hiding this comment.
Good catch
Secret entities not only contain secrets in data, but might also contain an annotation that represents the previous configuration for this Secret, including the secrets. Drop such annotation
obs-gh-enricogiorio
force-pushed
the
enrico/obfuscateSecrets
branch
from
68d0f04
to
141bc90
Compare
xueweiz
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret entities not only contain secrets in data, but might also contain
an annotation that represents the previous configuration for this
Secret, including the secrets. Drop such annotation