feat: rework config to allow for inclusion/exclusion of features #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-alexlew
commented
May 1, 2024
| @@ -0,0 +1,36 @@ | |||
| receivers: | |||
There was a problem hiding this comment.
@NathanNam as part of this change I'm splitting the overall config into subconfigs for logs and metrics that we can include/exclude based on whether enabled is set in the top level config and then a base config. just want you to be aware of the new structure of the config files. also, we can't support any pipelines that require both to be enabled namely the count connector since then the state where either is disabled is invalid. will be a limitation in general that we'd have to work around. so basically all features/configs need to be independent of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-2999 Please explain the changes you made here.
Checklist