feat: Add observe_monitor_v2 resource #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramraman
requested changes
Jul 2, 2024
| return diags | ||
| } | ||
|
|
||
| id, _ := oid.NewOID(data.Get("workspace_id").(string)) |
There was a problem hiding this comment.
Should we just add a MustNewOID and panic if it fails for these cases where we expect it to always work?
vikramraman
reviewed
Jul 17, 2024
vikramraman
requested changes
Jul 19, 2024
vikramraman
approved these changes
Jul 22, 2024
vikramraman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.