Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make Protbuf work with Confluent Schema registry #221

Closed
suchitgupta01 opened this issue Dec 2, 2020 · 7 comments
Closed

How to make Protbuf work with Confluent Schema registry #221

suchitgupta01 opened this issue Dec 2, 2020 · 7 comments

Comments

@suchitgupta01
Copy link

I am using Kafdrop docker image and we are exploring Protbuf format.

I see Kafdrop do support Protbuf but not sure how it can work with Confluent schema registry.

The schema is defined in Confluent and have posted a messages but I am getting an error message "No available descriptor, please check."

Going through the docs look like we need to define the location of proto files. But keeping all the proto files in one place might not be a case for us, so question is can't it get the schema from Confluent Schema registry?

@ctrongduc
Copy link

At the time we build protobuf support it was not supported by shema registry, thus it's not a built in feature.
Need to change code to get it worked with schema registry.

@suchitgupta01
Copy link
Author

@ctrongduc Got it. thanks!! Is this planned for the future?

@ctrongduc
Copy link

nothing planned yet, I could have a look and see what is the needed effort for this feature.

@simsibimsiwimsi
Copy link
Contributor

Hi @ctrongduc I did not see the issue before I started to take care of the feature as I need it myself. I have the code needed in place and would be happy to contribute it. Basically I added an additional Deserializer similar to AvroMessageDeserializer and adjusted MessageController to use it if no Protobuf Descriptor file is supplied.

@baganokodo
Copy link

Hi @ctrongduc I did not see the issue before I started to take care of the feature as I need it myself. I have the code needed in place and would be happy to contribute it. Basically I added an additional Deserializer similar to AvroMessageDeserializer and adjusted MessageController to use it if no Protobuf Descriptor file is supplied.

Hi @simsibimsiwimsi could you share your code? I am facing the exact same challenge today.

Thank you

@simsibimsiwimsi
Copy link
Contributor

Hi @ctrongduc I did not see the issue before I started to take care of the feature as I need it myself. I have the code needed in place and would be happy to contribute it. Basically I added an additional Deserializer similar to AvroMessageDeserializer and adjusted MessageController to use it if no Protobuf Descriptor file is supplied.

Hi @simsibimsiwimsi could you share your code? I am facing the exact same challenge today.

Thank you

Hi @baganokodo - already done in #225

ekoutanov added a commit that referenced this issue Apr 11, 2021
#221 Added support for Schema Registry with Protobuf
@baganokodo
Copy link

The PR is merged, should this ticket be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants