-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added github actions to build and release #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much!
Maybe we should delete .github/workflows/maven.yml
?
I don't have permission to setup github actions variables, I think we need @ekoutanov .
The maven.yml will also run on PRs. Therefore I think it's better to keep it. |
Feel free to do whatever you want with the maven.yml. I just added it to my former PR because there "just" was Travis CI which I could not use for server-side test execution. |
run github release action first to precent overwriting existing releases.
@ekoutanov I would really love to see a release without log4j issues. |
I'll try to get around to it. |
@kbudde @ekoutanov @mcs https://github.com/marketplace/actions/upload-files-to-a-github-release |
yeah, Bintray's kaput. We can skip it if the binaries can be uploaded elsewhere. |
@davideicardi , @ekoutanov I fixed it and updated the description. The github workflow will now create the github release and a tag(!) if the version in pom.xml does end on "-SNAPSHOT". @ekoutanov only the dockerhub token is needed anymore. I've also cleaned up the CI files. Release workflow:
Each commit on master will push container to dockerhub: |
Great work @kbudde ! Thank you! |
Added secrets |
@kbudde The new action seems to work without problems! |
Hi,
I've added a github action to build and deploy as travis was doing it before.
You must add the following secrets to your repository:
#323